chore: new relay tests #1649
chore: new relay tests #1649
Conversation
size-limit report 📦
|
…re/new-relay-tests
…re/new-relay-tests
…re/new-relay-tests
…re/new-relay-tests
fbarbu15
added
the
E:End-to-end testing
| expect(bytesToUtf8(receivedMsg.payload!)).to.eq(messageText); | ||
| }); | ||
|
|
||
| describe.skip("Two nodes connected to nwaku", function () { |
There was a problem hiding this comment.
Thanks, Great catch. I've missed this .skip because It was an existing test that was skipped for some reason.
However I see that It can be fixed and seems to work fine.
Will unskip it
|
|
||
| // Seems that there are duplicates messages for this scenario | ||
| // Skipping until finding a resolution | ||
| it.skip("Refresh subscription", async function () { |
There was a problem hiding this comment.
Let's make an issue for tracking it?
| @@ -50,7 +50,8 @@ export const TEST_STRING = [ | |||
| { description: "JSON", value: '{"user":"admin","password":"123456"}' }, | |||
| { description: "shell command", value: "`rm -rf /`" }, | |||
| { description: "escaped characters", value: "\\n\\t\\0" }, | |||
| { description: "unicode special characters", value: "\u202Ereverse" } | |||
| { description: "unicode special characters", value: "\u202Ereverse" }, | |||
| { description: "emoji", value: "🤫 🤥 😶 😶🌫️ 😐 😑 😬 🫨 🫠 🙄 😯 😦 😧 😮" } | |||
There was a problem hiding this comment.
If I understand correctly, these are testing the utf8ToByte utils functions which are here are helpers and not expected to be used by any serious project.
using fast-check to generate arbitrary byte arrays as payload may be a better approach @fbarbu15
There was a problem hiding this comment.
Indeed for some cases, those string are converted to bytes when sending the message, and then upon assertion converted back from bytes to string. So in those cases you are right, we are actually checking the utils and using fast-check indeed looks a better approach.
But there are cases when we use those string as contentTopic, and in that case I think it's more relevant to have those kind of hardcoded edge cases. Ex of such message retrieved from nwaku:
{
payload: '8J+kqyDwn6SlIPCfmLYg8J+YtuKAjfCfjKvvuI8g8J+YkCDwn5iRIPCfmKwg8J+rqCDwn6ugIPCfmYQg8J+YryDwn5imIPCfmKcg8J+Yrg==',
contentTopic: '🤫 🤥 😶 😶🌫️ 😐 😑 😬 🫨 🫠 🙄 😯 😦 😧 😮',
version: 0,
timestamp: 1698130469857000000,
ephemeral: false
}
Problem
Solution
New tests for the relay protocol
Split existing relay tests into multiple suites