fix: measure total message size #1643
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
size-limit report 📦
|
fryorcraken
force-pushed
the
fix/measure-total-message-size
branch
from
f91c112 to
d9b9709
Compare
fryorcraken
force-pushed
the
fix/measure-total-message-size
branch
3 times, most recently
from
e7f04d6 to
3a0e2c7
Compare
Network message limitations are imposed on the whole message, not just the payload.
fryorcraken
force-pushed
the
fix/measure-total-message-size
branch
from
3a0e2c7 to
559082e
Compare
|
@fbarbu15 I removed the "exact 1MB message size" tests because they are actually hard to setup as the protobuf boilerplate needs to be taken in account and not sure how useful. |
|
@fryorcraken , is it that you noticed or there was an issue with that particular case? |
Merged
I noticed the problem because I did change in the area for my previous PR and I recently read the RFC about the Waku Network and hence noticed the discrepancy. |
danisharora099
pushed a commit
that referenced
this pull request
Nov 2, 2023
Network message limitations are imposed on the whole message, not just the payload. Co-authored-by: Sasha <118575614+weboko@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Network message limitations are imposed on the whole message, not just
the payload.