Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: fix quick start link in the main README.md file #1607

Merged
merged 3 commits into from
Sep 22, 2023

Conversation

Ivansete-status
Copy link
Contributor

Problem

When trying to visit the "quick start" guide I saw the next:
image

Solution

Either put the correct link or create the page for https://docs.waku.org/guides/js-waku/quick-start.
In this PR I'm just adding a link that I think is correct, but not sure :D

@Ivansete-status Ivansete-status requested a review from a team as a code owner September 22, 2023 10:21
@github-actions
Copy link

github-actions bot commented Sep 22, 2023

size-limit report 📦

Path Size Loading time (3g) Running time (snapdragon) Total time
Waku core 27.69 KB (0%) 554 ms (0%) 369 ms (-0.34% 🔽) 922 ms
Waku Simple Light Node 262.6 KB (0%) 5.3 s (0%) 1.5 s (+46.36% 🔺) 6.8 s
ECIES encryption 28.7 KB (0%) 574 ms (0%) 347 ms (-22.96% 🔽) 921 ms
Symmetric encryption 28.7 KB (0%) 575 ms (0%) 360 ms (-15.25% 🔽) 934 ms
DNS discovery 110.62 KB (0%) 2.3 s (0%) 641 ms (-2.73% 🔽) 2.9 s
Privacy preserving protocols 117.38 KB (0%) 2.4 s (0%) 776 ms (+65.26% 🔺) 3.2 s
Light protocols 25.83 KB (0%) 517 ms (0%) 359 ms (+1.41% 🔺) 875 ms
History retrieval protocols 24.9 KB (0%) 499 ms (0%) 306 ms (+11.86% 🔺) 804 ms
Deterministic Message Hashing 5.65 KB (0%) 113 ms (0%) 131 ms (-29.55% 🔽) 244 ms

@danisharora099
Copy link
Collaborator

thank you ivan!

@Ivansete-status
Copy link
Contributor Author

Anyone who agrees with the change, please merge it directly.
I can't myself snif snif:
image

@weboko weboko merged commit db46217 into master Sep 22, 2023
@weboko weboko deleted the fix-quick-start-link branch September 22, 2023 15:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants