-
Notifications
You must be signed in to change notification settings - Fork 43
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: enable event emission for peer discovery/connection in ConnectionManager #1438
Merged
+384
−117
Merged
Changes from 1 commit
Commits
Show all changes
20 commits
Select commit
Hold shift + click to select a range
95715d4
disable libp2p autodial
danisharora099 34e22ad
improve logs for peer-exchange
danisharora099 164508c
add a function to fetch discovered and connected peers by discovery
danisharora099 1e0708b
connection-manager: introduce event emissions by discovery
danisharora099 dfa3618
write a spec test for events
danisharora099 da6b661
minor code improvement for peer-exchange
danisharora099 b815615
rm: comment
danisharora099 15a9484
Merge branch 'master' into feat/improve-conn-manager
danisharora099 fb8ae26
rename peer event result interface
danisharora099 a32e9de
Merge branch 'feat/improve-conn-manager' of github.com:waku-org/js-wa…
danisharora099 5c6074c
switch to using libp2p EventEmitter
danisharora099 82b9239
rename variables for readability
danisharora099 81539c2
reset peer-exchange spec file
danisharora099 fc07c9a
address review
danisharora099 9e6aece
Merge branch 'master' into feat/improve-conn-manager
danisharora099 dae61fa
test: minor refactor
danisharora099 9d28213
fix: failing test
danisharora099 ba03bc3
increase peer IDs to test against for attemptDial
danisharora099 9d777c9
improve structuring
danisharora099 81c2544
Merge branch 'master' into feat/improve-conn-manager
danisharora099 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
rename peer event result interface
commit fb8ae26c0550292861de885a2f4e8319f815ae12
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I guess we can optimize here and just
getConnections
which returns tags as well so that later there is no reason to await for peer storeThere was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
correct. that is a more efficient way, agreed.
related comment: #1438 (comment)