Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat!: rename package from @waku/create to @waku/sdk #1386

Merged
merged 9 commits into from
Jun 5, 2023
Merged

feat!: rename package from @waku/create to @waku/sdk #1386

Show file tree
Hide file tree
Changes from 2 commits
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
62f2737
feat!(@waku/sdk): rename package from @waku/create to @waku/sdk
danisharora099 May 30, 2023
4a9c74e
feat: proxy @waku/core and @waku/utils through @waku/sdk
danisharora099 May 30, 2023
b5e9139
address comments
danisharora099 Jun 3, 2023
0163116
Merge branch 'master' of github.com:waku-org/js-waku into feat/waku-sdk
danisharora099 Jun 3, 2023
eda5f6b
update package-lock
danisharora099 Jun 3, 2023
a36c826
Update .size-limit.cjs
weboko Jun 5, 2023
90e37ac
integrate to release please
weboko Jun 5, 2023
33b980d
Merge branch 'feat/waku-sdk' of github.com:waku-org/js-waku into feat…
weboko Jun 5, 2023
0ec7873
Merge branch 'master' of github.com:waku-org/js-waku into feat/waku-sdk
weboko Jun 5, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions .size-limit.cjs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,9 +6,9 @@ module.exports = [
},
{
name: "Waku default setup",
path: ["packages/create/bundle/index.js", "packages/core/bundle/index.js"],
path: ["packages/sdk/bundle/index.js", "packages/core/bundle/index.js"],
import: {
"packages/create/bundle/index.js": "{ createLightNode }",
"packages/sdk/bundle/index.js": "{ createLightNode }",
"packages/core/bundle/index.js":
"{ waitForRemotePeer, createEncoder, createDecoder }",
},
Expand Down
250 changes: 167 additions & 83 deletions package-lock.json
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,7 @@
"packages/peer-exchange",
"packages/dns-discovery",
"packages/message-encryption",
"packages/create",
"packages/sdk",
"packages/tests",
"packages/build-utils"
],
Expand Down
2 changes: 1 addition & 1 deletion packages/core/src/lib/wait_for_remote_peer.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,7 @@ const log = debug("waku:wait-for-remote-peer");
* Wait for a remote peer to be ready given the passed protocols.
* Must be used after attempting to connect to nodes, using
* {@link @waku/core.WakuNode.dial} or a bootstrap method with
* {@link @waku/create.createLightNode}.
* {@link @waku/sdk.createLightNode}.
*
* If the passed protocols is a GossipSub protocol, then it resolves only once
* a peer is in a mesh, to help ensure that other peers will send and receive
Expand Down
0 packages/create/.eslintrc.cjs → packages/sdk/.eslintrc.cjs
View file
Open in desktop
File renamed without changes.
0 packages/create/CHANGELOG.md → packages/sdk/CHANGELOG.md
View file
Open in desktop
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I hope release please will handle the git label change properly...

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

cc @weboko

File renamed without changes.
9 changes: 5 additions & 4 deletions packages/create/package.json → packages/sdk/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
{
"name": "@waku/create",
"version": "0.0.14",
"description": "Easily create a Waku node",
"name": "@waku/sdk",
"version": "0.0.15",
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hum, so the idea is to manual release after this PR is merged? Sounds good, let's be sure you then tell release please to start from this version.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

cc @weboko

Copy link
Collaborator

@weboko weboko Jun 5, 2023 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This one requires us to remove @waku/create from release-please files and add @waku/sdk to the list of packages being tracked and to manually set next version.

After release of this package happens we need to remove forced version of sdk package`.

"description": "A unified SDK for easy creation and management of js-waku nodes.",
"types": "./dist/index.d.ts",
"module": "./dist/index.js",
"exports": {
Expand All @@ -12,7 +12,7 @@
},
"type": "module",
"author": "Waku Team",
"homepage": "https://github.com/waku-org/js-waku/tree/master/packages/create#readme",
"homepage": "https://github.com/waku-org/js-waku/tree/master/packages/sdk#readme",
"repository": {
"type": "git",
"url": "https://github.com/waku-org/js-waku.git"
Expand Down Expand Up @@ -53,6 +53,7 @@
"@libp2p/websockets": "^5.0.3",
"@waku/relay": "0.0.1",
"@waku/core": "0.0.18",
"@waku/utils": "*",
"@waku/dns-discovery": "0.0.12",
"libp2p": "^0.42.2"
},
Expand Down
0 packages/create/rollup.config.js → packages/sdk/rollup.config.js
View file
Open in desktop
File renamed without changes.
0 packages/create/src/index.ts → packages/sdk/src/create.ts
View file
Open in desktop
File renamed without changes.
3 changes: 3 additions & 0 deletions packages/sdk/src/index.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,3 @@
export * from "./create.js";
export * as waku from "@waku/core";
export * as utils from "@waku/utils";
0 packages/create/src/libp2p_components.ts → packages/sdk/src/libp2p_components.ts
View file
Open in desktop
File renamed without changes.
0 packages/create/tsconfig.dev.json → packages/sdk/tsconfig.dev.json
View file
Open in desktop
File renamed without changes.
0 packages/create/tsconfig.json → packages/sdk/tsconfig.json
View file
Open in desktop
File renamed without changes.
2 changes: 1 addition & 1 deletion packages/tests/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -72,7 +72,7 @@
"@types/tail": "^2.2.1",
"@typescript-eslint/eslint-plugin": "^5.57.0",
"@typescript-eslint/parser": "^5.51.0",
"@waku/create": "*",
"@waku/sdk": "*",
"@waku/dns-discovery": "*",
"@waku/message-encryption": "*",
"@waku/peer-exchange": "*",
Expand Down
Loading