refactor: change eth-pm using lightnode, filter to now use relay

[danisharora099]

This PR addresses #88:

• switch the example from using light node with filter and store to now using relay
• setup craco as the bundler

TODO/confirm:

• the number on waku.relay.getPeers() does not return a number more than 1 for some reason

[fryorcraken]

the number on waku.relay.getPeers() does not return a number more than 1 for some reason

Yep that's expected as we only connect to one peer by default.

We can change that once we have implement Waku peer exchange, did some dog fooding of DNS Discovery and run a second operator trial to ensure there are enough nodes to connect to.

[danisharora099]

the number on waku.relay.getPeers() does not return a number more than 1 for some reason

Yep that's expected as we only connect to one peer by default.

We can change that once we have implement Waku peer exchange, did some dog fooding of DNS Discovery and run a second operator trial to ensure there are enough nodes to connect to.

Gotcha ok!

Also, not sure why the CI hasn't executed on these yet 🤔

[fryorcraken]

Oooh, does this remove all the sourcemap warnings? Interesting. I did do some upstream PR to help with those ChainSafe/js-libp2p-gossipsub#337

[danisharora099]

Yes, this doesn't generate sourcemap altogether; don't think we need it in our case.

[fryorcraken]

Where do you use the typing?

[danisharora099]

I was trying to initiialise craco.config.js in ts instead so installed types, but ended up reverting to js because of some weird bugs and, from what it looked like, the lack of TS support on craco.

Pushed a commit to remove this as a dependency.

[fryorcraken]

Please confirm you tested locally and it still works.
Also need to sign your commits to merge.

[fryorcraken]

Not sure what is going with the CI checks. Let's see if they get triggered when you force push after signing

[danisharora099]

Not sure why the build on the CI is failing -- it builds fine for me locally 👀

[fryorcraken]

Not sure why the build on the CI is failing -- it builds fine for me locally eyes

Best to look at the logs to understand the failure:

Run pnpm install --frozen-lockfile
Lockfile is up to date, resolution step is skipped
 ERR_PNPM_OUTDATED_LOCKFILE  Cannot install with "frozen-lockfile" because pnpm-lock.yaml is not up to date with package.json

Note that in CI environments this setting is true by default. If you still need to run install in such cases, use "pnpm install --no-frozen-lockfile"
Error: Process completed with exit code 1.

I am guessing you did not commit changes to the pnpm-lock.file after removing the @types/_craco_craco dependency.
Or maybe did not run pnpm after removing the dependency.

[danisharora099]

ok fixed - can merge it now @fryorcraken

[fryorcraken]

@danisharora099 some commits are not signed and I can't easily resign your commits (I am assuming there's a merge commit in there?). I'd suggest you squash, sign and push.

[fryorcraken]

@danisharora099 some commits are not signed and I can't easily resign your commits (I am assuming there's a merge commit in there?). I'd suggest you squash, sign and push.

Ignore that, I squashed and signed.