Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[v3] actions improvements & run actions on more branches and in forks #3747

Merged
merged 4 commits into from
Sep 14, 2024

Conversation

stendler
Copy link

@stendler stendler commented Sep 14, 2024

Description

  • update used actions to use newer node 20 and get rid of warnings
  • don't fail fast in OS matrix to allow seeing if only one system is affected
  • also run build-and-test-alpha on branches prefixed with v3/ or v3-
  • enable to run in forks to make testing easier (no quota for public repos)
  • add cache dependency path for setup-go to enable caching (and get rid of the warning, that no go.sum was found in the project root)

Type of change

  • CI / actions

How Has This Been Tested?

As part of the actions in my fork: https://github.com/stendler/wails/actions

Checklist:

  • I have updated website/src/pages/changelog.mdx with details of this PR
  • I have performed a self-review of my own code

Summary by CodeRabbit

  • Chores
    • Enhanced build and testing processes in the CI/CD pipeline.
    • Expanded workflow triggers to include more branch patterns.
    • Updated various actions to their latest versions for improved performance and efficiency.
    • Changed the fail-fast strategy to allow all jobs to run to completion, enhancing visibility of test results.
    • Improved Events API with clearer event handling methods and fixes for better functionality.

Copy link
Contributor

coderabbitai bot commented Sep 14, 2024

Walkthrough

The GitHub Actions workflow file .github/workflows/build-and-test-alpha.yml has been updated to enhance the build and testing processes. The trigger conditions have been expanded to include additional branch patterns. Several actions used in the workflow have been upgraded to their latest versions to improve dependency management and caching efficiency. Additionally, the fail-fast strategy has been modified to allow all jobs to run to completion, providing better visibility into test results.

Changes

File Change Summary
.github/workflows/build-and-test-alpha.yml - Expanded workflow triggers to include branches v3/* and v3-*.
- Updated actions to latest versions:
actions/checkout from v3 to v4,
actions/setup-go from v3 to v5,
arduino/setup-task from v1 to v2,
actions/setup-node from v3 to v4,
actions/cache from v3 to v4.
- Changed fail-fast strategy from true to false for test_go and test_js jobs.
mkdocs-website/docs/en/changelog.md - Updated Events API with method renaming for better event handling.
- Fixed Linux-specific issue in Events API.
- Enhanced CI actions to run in forks and branches prefixed with v3/ or v3-.
- Resolved bug in customEventProcessor for drag-and-drop example.

Sequence Diagram(s)

sequenceDiagram
    participant User
    participant GitHub Actions
    participant Build System
    participant Test System

    User->>GitHub Actions: Push code to branch
    GitHub Actions->>Build System: Trigger build
    Build System->>GitHub Actions: Build completed
    GitHub Actions->>Test System: Run tests
    Test System-->>GitHub Actions: Tests results
    GitHub Actions-->>User: Notify results
Loading

Poem

🐰 In the meadow where code does play,
Upgraded actions brighten the day.
Branches now dance in a wider array,
With tests that run, come what may!
Hops of joy in the CI flow,
Let’s build and test, watch our project grow! 🌼

Tip

OpenAI O1 model for chat
  • We have deployed OpenAI's latest O1 model for chat.
  • OpenAI claims that this model has superior reasoning capabilities than their GPT-4o model.
  • Please share any feedback with us in the discussions post.

Recent review details

Configuration used: .coderabbit.yaml
Review profile: CHILL

Commits

Files that changed from the base of the PR and between d3dbda8 and 363c24f.

Files selected for processing (2)
  • .github/workflows/build-and-test-alpha.yml (4 hunks)
  • mkdocs-website/docs/en/changelog.md (1 hunks)
Files skipped from review as they are similar to previous changes (1)
  • .github/workflows/build-and-test-alpha.yml
Additional comments not posted (1)
mkdocs-website/docs/en/changelog.md (1)

27-27: CI improvements enhance development flexibility.

The changes to the CI actions, allowing them to run in forks and branches prefixed with v3/ or v3-, are a valuable improvement to the development process. This flexibility enables easier testing and collaboration without the limitations of public repositories.

Great work on this enhancement! It streamlines the workflow and benefits all contributors.


Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share
Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai generate interesting stats about this repository and render them as a table.
    • @coderabbitai show all the console.log statements in this repository.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@leaanthony
Copy link
Member

Thanks for taking the time to do this - it was due some TLC🙏

Please could you add an entry to the changelog located at mkdocs-website/docs/changelog.md? Thanks!

Copy link

@stendler
Copy link
Author

@leaanthony I wasn't sure, if this change was worthy of an entry, as it changed nothing in wails per se. I've added one now!

@leaanthony leaanthony merged commit 56494d8 into wailsapp:v3-alpha Sep 14, 2024
15 of 16 checks passed
@leaanthony
Copy link
Member

Really appreciate this 🙏

@leaanthony
Copy link
Member

@leaanthony I wasn't sure, if this change was worthy of an entry, as it changed nothing in wails per se. I've added one now!

Of course! The project is more than just code and we appreciate all efforts to improve the project as a whole 🙏

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants