-
Notifications
You must be signed in to change notification settings - Fork 59
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Mapname key parser (map version translation fix) #534
Conversation
pulling versions out on the Winrates page now. Wanted to check that all these dashes and underscores could be turned into periods before doing so (this doesn't fix #501 , but could allow for a version dropdown to look nicer if that work were done) |
@@ -279,6 +281,9 @@ const en = { | |||
// S10 | |||
"ShatteredExilev2-07": "Shattered Exile", | |||
|
|||
// S12 | |||
springtime: "Springtime", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
some maps only have a "versionless" name in PascalCase, some only have one in lowercase. This change would break some tags unless translations of the base name were copied to be lowercase. Open to making PascalCase the default as well, but en.ts has way more in lowercase from what I could see
related to #416, could be applied also to #501
It seems like there are many places where we rely on these keys to be updated. I thought it would be nice to just split the version off the key, so the display isn't broken every time a map is updated.
Let me know if you don't want to add
jest
and all that to the devDeps, it was just the fastest way to prove to myself that the function was working as intended. Please see the test file for two examples, and feel free to point out other cases.Do people think it's important to show the version as well? I pull it out, as you can see.
specific fix is for this UI, rendered by

RaceToMapStat.vue