Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't fire connectionstatechange on pc.close(). #2876

Merged
merged 3 commits into from
Jul 13, 2023
Merged

Don't fire connectionstatechange on pc.close(). #2876

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
c26c426
Don't fire connectionstatechange on pc.close().
jan-ivar Jun 2, 2023
46a3411
Tweak markup for amendment
dontcallmedom Jun 16, 2023
2b3d707
Merge branch 'main' into noconnectionstateclose
jan-ivar Jul 13, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 10 additions & 0 deletions amendments.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -501,5 +501,15 @@
"status": "candidate",
"id": 34
}
],
"connectionstate-algo": [
{
"description": "Don't fire connectionstatechange on pc.close()",
"pr": 2876,
"difftype": "append",
"type": "correction",
"status": "candidate",
"id": 35
}
]
}
2 changes: 1 addition & 1 deletion base-rec.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2264,7 +2264,7 @@ <h5 id="x4-4-1-3-update-the-connection-state"><bdi class="secno">4.4.1.3 </bdi>
task that runs the following steps:
</p>
<ol data-tests="RTCPeerConnection-connectionState.https.html" class="has-tests">
<li class="no-test-needed">
<li class="no-test-needed" id="connectionstate-algo">
<p>
Let <var>connection</var> be this <a data-link-type="idl" href="#dom-rtcpeerconnection" class="internalDFN" id="ref-for-dom-rtcpeerconnection-25"><code><code>RTCPeerConnection</code></code></a>
object.
Expand Down
16 changes: 10 additions & 6 deletions webrtc.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1569,16 +1569,20 @@ <h4>
<p>
An {{RTCPeerConnection}} object has an aggregated
{{RTCPeerConnection/[[ConnectionState]]}}.
Whenever the state of an {{RTCDtlsTransport}} changes
or when the {{RTCPeerConnection/[[IsClosed]]}} slot turns <code>true</code>,
the user agent MUST update the connection state by queueing a
task that runs the following steps:
Whenever the state of an {{RTCDtlsTransport}} changes,
the user agent MUST queue a task that runs the following steps:
</p>
<ol class=algorithm data-tests="RTCPeerConnection-connectionState.https.html">
<li class="no-test-needed">
<li class="no-test-needed" id="connectionstate-algo">
<p>
Let <var>connection</var> be this {{RTCPeerConnection}}
object.
object associated with the {{RTCDtlsTransport}} object whose state changed.
</p>
</li>
<li class="add-to-connectionstate-algo">
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this a proper use of the "class" attribute?

<p>
If <var>connection</var>.{{RTCPeerConnection/[[IsClosed]]}} is
<code>true</code>, abort these steps.
</p>
</li>
<li>
Expand Down