Create RTCRtpCodec dictionary and reuse in RTCRtpCodecParameters and RTCRtpCodecCapability definitions #2834
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Orphis
force-pushed
the
merge_codec_definitions
branch
2 times, most recently
from
dc3c905 to
fe13b5f
Compare
dontcallmedom
force-pushed
the
merge_codec_definitions
branch
from
fe13b5f to
f7ed8ea
Compare
Those two objects are closely related and the parameters type should reuse the capability definition to prevent them from diverging. It would also allow using an RTCRtpCodecParameters instance with the upcoming encoder codec selection API.
Orphis
force-pushed
the
merge_codec_definitions
branch
from
f7ed8ea to
9d7c8e8
Compare
Orphis
changed the title
|
I think this is a good and backwards-compatible change, which unifies definitions that are identical in a single place, preventing later divergence. |
henbos
approved these changes
Mar 16, 2023
jan-ivar
reviewed
Mar 16, 2023
jan-ivar
approved these changes
Mar 16, 2023
youennf
approved these changes
Mar 16, 2023
23 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
RTCRtpCodecParameters and RTCRtpCodecCapability are closely defined and would benefit from sharing their common members to prevent them from diverging.
It would also allow using an RTCRtpCodec instance with the upcoming encoder codec selection API.
Preview | Diff