Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add url attribute to RTCIceCandidate #2773

Merged
merged 2 commits into from
Oct 27, 2022
+36 −4
Merged

add url attribute to RTCIceCandidate #2773

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
66f44f1
add url attribute to RTCIceCandidate
fippo Oct 25, 2022
73a0a9c
document amendment
fippo Oct 25, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 16 additions & 0 deletions amendments.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -196,6 +196,15 @@
"id": 16
}
],
"rtcpeerconnectioniceevent-attributes": [
{
"description": "Add deprecation notice to RTCPeerConnectionIceEvent.url",
"pr": 2773,
"type": "correction",
"status": "candidate",
"id": 23
}
],
"rtcicecandidate-attributes": [
{
"description": "Add RTCIceCandidate.relayProtocol",
Expand All @@ -204,6 +213,13 @@
"type": "addition",
"status": "candidate",
"id": 16
},
{
"description": "Add RTCIceCandidate.url",
"pr": 2773,
"type": "addition",
"status": "candidate",
"id": 23
}
],
"rtcicecredentialtype-enum": [
Expand Down
4 changes: 2 additions & 2 deletions base-rec.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7016,9 +7016,9 @@ <h5 id="constructors-2">
</dl>
</section>
<section>
<h5 id="attributes-5">
<h5 id="rtcpeerconnectioniceevent-attributes">
Attributes
<a class="self-link" aria-label="§" href="#attributes-5"></a></h5>
<a class="self-link" aria-label="§" href="#rtcpeerconnectioniceevent-attributes"></a></h5>
<dl data-link-for="RTCPeerConnectionIceEvent" data-dfn-for="RTCPeerConnectionIceEvent" class="attributes">
<dt data-tests="RTCPeerConnectionIceEvent-constructor.html" class="has-tests">
<dfn data-idl="attribute" data-export="" data-dfn-type="attribute" id="dom-rtcpeerconnectioniceevent-candidate" data-title="candidate" data-dfn-for="RTCPeerConnectionIceEvent" data-type="RTCIceCandidate" data-lt="candidate" data-local-lt="RTCPeerConnectionIceEvent.candidate"><code>candidate</code></dfn> of type <span class="idlAttrType"><a data-link-type="idl" href="#dom-rtcicecandidate" class="internalDFN" id="ref-for-dom-rtcicecandidate-15"><code><code>RTCIceCandidate</code></code></a></span>, readonly, nullable
Expand Down
20 changes: 18 additions & 2 deletions webrtc.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5938,6 +5938,7 @@ <h4>
readonly attribute unsigned short? relatedPort;
readonly attribute DOMString? usernameFragment;
readonly attribute RTCIceServerTransportProtocol? relayProtocol;
readonly attribute DOMString? url;
RTCIceCandidateInit toJSON();
};</pre>
<section>
Expand Down Expand Up @@ -6250,6 +6251,17 @@ <h2>
is only present for local relay candidates.
</p>
</dd>
<dt class="add-to-rtcicecandidate-attributes">
<dfn>url</dfn> of type <span class=
"idlMemberType">DOMString</span>
</dt>
<dd class="add-to-rtcicecandidate-attributes">
<p>
For local candidates of type {{RTCIceCandidateType/"srflx"}} or type
{{RTCIceCandidateType/"relay"}} this is the URL of the ICE server
from which the candidate was obtained.
</p>
</dd>
</dl>
</section>
<section>
Expand Down Expand Up @@ -6648,7 +6660,7 @@ <h4>
</ul>
</div>
<div>
<pre class="idl" data-tests="idlharness.https.window.js">[Exposed=Window]
<pre class="idl" data-tests="idlharness.https.window.js" id="webidl-rtcpeerconnectioniceevent">[Exposed=Window]
interface RTCPeerConnectionIceEvent : Event {
constructor(DOMString type, optional RTCPeerConnectionIceEventInit eventInitDict = {});
readonly attribute RTCIceCandidate? candidate;
Expand All @@ -6671,7 +6683,7 @@ <h2>
Attributes
</h2>
<dl data-link-for="RTCPeerConnectionIceEvent" data-dfn-for=
"RTCPeerConnectionIceEvent" class="attributes">
"RTCPeerConnectionIceEvent" id="rtcpeerconnectioniceevent-attributes" class="attributes">
<dt data-tests="RTCPeerConnectionIceEvent-constructor.html">
<dfn data-idl="">candidate</dfn> of type <span class=
"idlAttrType">{{RTCIceCandidate}}</span>, readonly, nullable
Expand Down Expand Up @@ -6702,6 +6714,10 @@ <h2>
TURN server, this parameter will be set to
<code>null</code>.
</p>
<p class="note" class="add-to-rtcpeerconnectioniceevent-attributes">
This attribute is deprecated; it exists for legacy compatibility reasons only.
Prefer the candidate {{RTCIceCandidate/url}}.
</p>
</dd>
</dl>
</section>
Expand Down