Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Convert generateCertificate argument to DOMHighResTimeStamp #2700

Merged
merged 3 commits into from
Dec 2, 2021
Merged

Convert generateCertificate argument to DOMHighResTimeStamp #2700

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
4538093
Convert generateCertificate argument to DOMHighResTimeStamp
alvestrand Nov 22, 2021
54aa470
Use long long
alvestrand Dec 2, 2021
33bcad9
Remove leftover added para
alvestrand Dec 2, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
21 changes: 17 additions & 4 deletions webrtc.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7030,6 +7030,12 @@ <h2>
certificate; a browser SHOULD select SHA-256 [[!FIPS-180-4]]
if a hash algorithm is needed.
</p>
<p>
The time used when generating a certificate is of type
{{DOMHighResTimeStamp}}, which means that it is a number
relative to the time origin as specified in [[HR-TIME]],
or "now" if the time origin is undefined.
</p>
<p>
The resulting certificate MUST NOT include information that
can be linked to a user or <a>user agent</a>. Randomized
Expand All @@ -7049,7 +7055,7 @@ <h2>
</li>
<li>
<p>
Let <var>expires</var> be a {{EpochTimeStamp}} value of
Let <var>expires</var> be a {{DOMHighResTimeStamp}} value of
2592000000.
</p>
<div class="note">
Expand Down Expand Up @@ -7235,21 +7241,28 @@ <h2>
{{RTCPeerConnection/generateCertificate}}.
</p>
<pre class="idl">dictionary RTCCertificateExpiration {
[EnforceRange] EpochTimeStamp expires;
[EnforceRange] DOMHighResTimeStamp expires;
};</pre>
<dl data-link-for="RTCCertificateExpiration" data-dfn-for=
"RTCCertificateExpiration" class="methods">
<dt data-tests=
"RTCPeerConnection-generateCertificate.html,RTCCertificate.html">
<dfn>expires</dfn>, of type {{EpochTimeStamp}}
<dfn>expires</dfn>, of type {{DOMHighResTimeStamp}}
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

use type "long long" and say "milliseconds relative to EpochTimestamp now()"

</dt>
<dd>
<p>
An optional {{expires}} attribute MAY be added to the
definition of the algorithm that is passed to
{{RTCPeerConnection/generateCertificate}}. If this parameter is
present it indicates the maximum time that the
{{RTCCertificate}} is valid for relative to the current time.
{{RTCCertificate}} is valid for.
</p>
<p class="note">
The expires attribute is relative to the time origin.
Previous versions of this specification claimed that it was
relative to the current time, but the definition of
{{DOMHighResTimeStamp}} precludes this interpretation.
The difference should not matter much in practice.
</p>
</dd>
</dl>
Expand Down