Merge pull request #2876 from jan-ivar/noconnectionstateclose

Don't fire connectionstatechange on pc.close().
w3c · Jul 13, 2023 · 98a2fc0 · 98a2fc0
2 parents bc552d5 + 2b3d707
commit 98a2fc0
Show file tree

Hide file tree

Showing 3 changed files with 21 additions and 7 deletions.
diff --git a/amendments.json b/amendments.json
@@ -501,5 +501,15 @@
       "status": "candidate",
       "id": 34
     }
+  ],
+  "connectionstate-algo": [
+    {
+      "description": "Don't fire connectionstatechange on pc.close()",
+      "pr": 2876,
+      "difftype": "append",
+      "type": "correction",
+      "status": "candidate",
+      "id": 35
+    }
   ]
 }
diff --git a/base-rec.html b/base-rec.html
@@ -2264,7 +2264,7 @@ <h5 id="x4-4-1-3-update-the-connection-state"><bdi class="secno">4.4.1.3 </bdi>
               task that runs the following steps:
             </p>
             <ol data-tests="RTCPeerConnection-connectionState.https.html" class="has-tests">
-              <li class="no-test-needed">
+              <li class="no-test-needed" id="connectionstate-algo">
                 <p>
                   Let <var>connection</var> be this <a data-link-type="idl" href="#dom-rtcpeerconnection" class="internalDFN" id="ref-for-dom-rtcpeerconnection-25"><code><code>RTCPeerConnection</code></code></a>
                   object.

diff --git a/webrtc.html b/webrtc.html
@@ -1569,16 +1569,20 @@ <h4>
             <p>
               An {{RTCPeerConnection}} object has an aggregated
               {{RTCPeerConnection/[[ConnectionState]]}}.
-              Whenever the state of an {{RTCDtlsTransport}} changes
-              or when the {{RTCPeerConnection/[[IsClosed]]}} slot turns <code>true</code>,
-              the user agent MUST update the connection state by queueing a
-              task that runs the following steps:
+              Whenever the state of an {{RTCDtlsTransport}} changes,
+              the user agent MUST queue a task that runs the following steps:
             </p>
             <ol class=algorithm data-tests="RTCPeerConnection-connectionState.https.html">
-              <li class="no-test-needed">
+              <li class="no-test-needed" id="connectionstate-algo">
                 <p>
                   Let <var>connection</var> be this {{RTCPeerConnection}}
-                  object.
+                  object associated with the {{RTCDtlsTransport}} object whose state changed.
+                </p>
+              </li>
+              <li class="add-to-connectionstate-algo">
+                <p>
+                  If <var>connection</var>.{{RTCPeerConnection/[[IsClosed]]}} is
+                  <code>true</code>, abort these steps.
                 </p>
               </li>
               <li>