Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Focus not obscured margin technique and working example #2746

Merged
merged 10 commits into from
Mar 6, 2023

Conversation

fstrr
Copy link
Contributor

@fstrr fstrr commented Oct 20, 2022

New technique and working example for Focus Not Obscured that will work for "minimum" and "enhanced" criteria.

Preview

@fstrr fstrr requested review from alastc and mbgower October 20, 2022 19:21
@fstrr fstrr changed the title Focus not obscured margin technique Focus not obscured margin technique and working example Oct 20, 2022
@detlevhfischer
Copy link
Contributor

@alastc
Copy link
Contributor

alastc commented Mar 3, 2023

Notes from the friday WCAG 2.x meeting:

  • Unfortunately making the cookie banner sticky at higher zoom levels makes it unusable, we need to revert that change.
  • We should have a message above saying that it is a demonstration of scroll-padding when at larger sizes, and it passes by being not-sticky at smaller sizes.

fstrr and others added 3 commits March 3, 2023 10:34
1. Added note about the `dialog` becoming un-fixed at smaller screen sizes so that the page doesn’t become unusable.
2. Removed some code from the Technique page so the content isn’t as long.
3. Added a space before the { characters

Also removed the note about lack of cross-browser support for the `:not` selector as that kind of thing goes stale.
@alastc alastc merged commit cbc4279 into main Mar 6, 2023
@patrickhlauke
Copy link
Member

patrickhlauke commented Mar 6, 2023

Btw, randomly, for an example in the wild ... I recently fixed this on the Bootstrap documentation site twbs/bootstrap#37926 (issue there includes a before/after video comparison)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants