Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Switch to EpochTimeStamp #338

Merged
merged 4 commits into from
Oct 20, 2021
Merged

Switch to EpochTimeStamp #338

merged 4 commits into from
Oct 20, 2021

Conversation

marcoscaceres
Copy link
Member

@marcoscaceres marcoscaceres commented Sep 9, 2021 •
edited by pr-preview bot
Loading

Closes #337

DOMTimeStamp is giong away:
whatwg/webidl#1021

It was renamed EpochTimeStamp and is now part of HR-Time:
w3c/hr-time#124

The following tasks have been completed:

  • Modified Web platform tests (link to pull request)

Implementation commitment:

Preview | Diff

@marcoscaceres marcoscaceres marked this pull request as draft September 9, 2021 07:29
@marcoscaceres marcoscaceres marked this pull request as ready for review October 11, 2021 05:15
@marcoscaceres marcoscaceres changed the title Switch to LegacyTimeStamp Switch to EpochTimeStamp Oct 11, 2021
@martinthomson
Copy link
Member

So DOMTimeStamp is nicely linked to the WebIDL spec. That means we don't really have to have a definition for it in this specification. I can't find a similar resource for EpochTimeStamp. Is this something that respec will sort out for us?

@marcoscaceres
Copy link
Member Author

marcoscaceres commented Oct 11, 2021 •
edited
Loading

Sorry, I should have given more context!

So DOMTimeStamp is nicely linked to the WebIDL spec.

DOMTimeStamp is giong away:
whatwg/webidl#1021

That means we don't really have to have a definition for it in this specification.

It was renamed EpochTimeStamp (because refactoring code, yay!!) and is now part of HR-Time:
w3c/hr-time#124

I can't find a similar resource for EpochTimeStamp. Is this something that respec will sort out for us?

Missing reference... fixing now :)

@marcoscaceres
Copy link
Member Author

marcoscaceres commented Oct 11, 2021 •
edited
Loading

Implemented .expirationTime it in Gecko (it doesn't do much right now, as I'm unsure if the Mozilla push service provides one, but it could be useful)... will send a patch.

Screen Shot 2021-10-11 at 6 33 38 pm

@marcoscaceres
Copy link
Member Author

Using Gecko bug https://bugzilla.mozilla.org/show_bug.cgi?id=1497431 ... sent a patch.

@beverloo
Copy link
Member

This is great Marcos, thank you! Looks good to me, and I filed a Chromium bug for us to move here:
https://bugs.chromium.org/p/chromium/issues/detail?id=1258800

beverloo
beverloo approved these changes Oct 11, 2021
View reviewed changes
Copy link
Member

@beverloo beverloo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We could simplify the subscription expiration time definition (line 184) a little bit, but the redundancy is minor and avoids having to cross-check with another document, so I'd be inclined to keep it.

@marcoscaceres
Copy link
Member Author

@beverloo, just a heads up that I've defaulted expirationTime = null; ... cleans up implementations a little bit, because no need to manually set it to null anymore.

@marcoscaceres marcoscaceres merged commit 2b9d9f9 into gh-pages Oct 20, 2021
@marcoscaceres marcoscaceres deleted the legacyTimeStamp branch October 20, 2021 05:56
moz-v2v-gh pushed a commit to mozilla/gecko-dev that referenced this pull request Nov 17, 2021
@marcoscaceres
Bug 1497431 - Implement PushManager.prototype.expirationTime + toJSON…
04a708a 
…() r=mt,peterv

Adds expirationTime to PushManager, which uses EpochTimeStamp.
See w3c/push-api#338

Differential Revision: https://phabricator.services.mozilla.com/D128046
moz-v2v-gh pushed a commit to mozilla/gecko-dev that referenced this pull request Nov 17, 2021
@marcoscaceres
Bug 1497431 - Implement PushManager.prototype.expirationTime + toJSON…
4281024 
…() r=mt,peterv

Adds expirationTime to PushManager, which uses EpochTimeStamp.
See w3c/push-api#338

Differential Revision: https://phabricator.services.mozilla.com/D128046
jamienicol pushed a commit to jamienicol/gecko that referenced this pull request Nov 18, 2021
@marcoscaceres
Bug 1497431 - Implement PushManager.prototype.expirationTime + toJSON…
a3973e6 
…() r=mt,peterv

Adds expirationTime to PushManager, which uses EpochTimeStamp.
See w3c/push-api#338

Differential Revision: https://phabricator.services.mozilla.com/D128046
jamienicol pushed a commit to jamienicol/gecko that referenced this pull request Nov 18, 2021
@marcoscaceres
Bug 1497431 - Implement PushManager.prototype.expirationTime + toJSON…
62545ad 
…() r=mt,peterv

Adds expirationTime to PushManager, which uses EpochTimeStamp.
See w3c/push-api#338

Differential Revision: https://phabricator.services.mozilla.com/D128046
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@beverloo beverloo beverloo approved these changes

@martinthomson martinthomson Awaiting requested review from martinthomson

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Consider using DOMHighResTimestamp instead of DOMTimeStamp
3 participants
@marcoscaceres @martinthomson @beverloo