fix #633 #637
Draft
fix #633 #637
+15
−35
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reorders and factorizes some parts of the 'Inverse Content Creation' algorithm.
It does not change the behaviour of the algorithm,
except for one corner case:
if the active context has no default language but has a default base direction,
the default combined tag is now _{dir}.
In the previous version, it was @none_{dir}.
I find this more consistent with steps 3.13.4 and 3.15.1,
and I suspect that this former discrepency was actually a bug.
|
I'll look at this further, but as at affects normative language, I think we need do do the Candidate Change markup with ins/del. |
|
Gosh, you are probably right 😓 |
TallTed
suggested changes
Feb 28, 2025
Co-authored-by: Ted Thibodeau Jr <tthibodeau@openlinksw.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This reorders and factorizes some parts of the 'Inverse Content Creation' algorithm.
It does not change the behaviour of the algorithm,
except for one corner case:
if the active context has no default language but has a default base direction,
the default combined tag is now {dir}.
In the previous version, it was @none{dir}.
I find this more consistent with steps 3.13.4 and 3.15.1,
and I suspect that this former discrepency was actually a bug.
NB: I put this PR on top of #636 because they affect the same part of the spec,
and because I don't expect #636 to be controversial anyway.
Preview | Diff