Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix[ux]: don't warn for logs with 0 positional args #4501

Merged

Conversation

charles-cooper
Copy link
Member

@charles-cooper charles-cooper commented Feb 28, 2025

this is especially annoying when -Werror is turned on!

What I did

How I did it

How to verify it

Commit message

per title. the existing logic would incorrectly warn for logs with 0
arguments (see the test in this commit). this commit fixes the logic.

Description for the changelog

Cute Animal Picture

Put a link to a cute animal picture inside the parenthesis-->

this is especially annoying when -Werror is turned on!
@charles-cooper charles-cooper marked this pull request as ready for review February 28, 2025 14:02
Copy link

codecov bot commented Feb 28, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 92.04%. Comparing base (d395dd0) to head (06e4a78).
Report is 1 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #4501   +/-   ##
=======================================
  Coverage   92.04%   92.04%           
=======================================
  Files         120      120           
  Lines       17361    17362    +1     
  Branches     2940     2941    +1     
=======================================
+ Hits        15980    15981    +1     
  Misses        964      964           
  Partials      417      417           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@cyberthirst cyberthirst added this to the v0.4.2 milestone Mar 10, 2025
@cyberthirst
Copy link
Collaborator

add a test case for == 0 args please

@charles-cooper charles-cooper changed the title fix[ux]: don't warn for logs when there are 0 positional args fix[ux]: don't warn for logs with 0 positional args Mar 10, 2025
@charles-cooper charles-cooper enabled auto-merge (squash) March 10, 2025 14:38
@charles-cooper charles-cooper merged commit 9b0106a into vyperlang:master Mar 10, 2025
159 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants