-
-
Notifications
You must be signed in to change notification settings - Fork 834
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix[codegen]: relax the filter for augassign oob check #4497
fix[codegen]: relax the filter for augassign oob check #4497
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #4497 +/- ##
=======================================
Coverage 92.06% 92.07%
=======================================
Files 120 120
Lines 17335 17343 +8
Branches 2935 2937 +2
=======================================
+ Hits 15960 15968 +8
Misses 957 957
Partials 418 418 ☔ View full report in Codecov by Sentry. |
transient augassign tests
@@ -293,7 +293,9 @@ def parse_AugAssign(self): | |||
if var.typ._is_prim_word: | |||
continue | |||
# oob - GHSA-4w26-8p97-f4jp | |||
if var in right.variable_writes or right.contains_risky_call: | |||
if var in right.variable_writes or ( | |||
var.is_state_variable() and right.contains_writeable_call |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
note: immutables count as state variables
What I did
relax the filter in #4487
How I did it
How to verify it
Commit message
Description for the changelog
Cute Animal Picture