Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat[venom]: add varname freshener #4484

Conversation

charles-cooper
Copy link
Member

@charles-cooper charles-cooper commented Feb 21, 2025

for when the varnames need to be "freshened" up. can be helpful for debugging

What I did

How I did it

How to verify it

Commit message

add a "freshen_varnames" method to IRFunction, which can help debugging
by renaming all variables, restarting from 0.

Description for the changelog

Cute Animal Picture

https://www.youtube.com/watch?v=-JfEJq56IwI&t=58s

@charles-cooper charles-cooper changed the base branch from venom-develop to master March 8, 2025 12:48
for when the varnames need to be "freshened" up. can be helpful for
debugging
@charles-cooper charles-cooper force-pushed the refactor/venom/freshen-varnames branch from 71b3d6d to dde121d Compare March 8, 2025 12:52
@charles-cooper charles-cooper enabled auto-merge (squash) March 8, 2025 12:54
@charles-cooper charles-cooper merged commit 072b386 into vyperlang:master Mar 8, 2025
159 checks passed
Copy link

codecov bot commented Mar 8, 2025

Codecov Report

Attention: Patch coverage is 16.66667% with 10 lines in your changes missing coverage. Please review.

Project coverage is 92.04%. Comparing base (18567f6) to head (dde121d).
Report is 1 commits behind head on master.

Files with missing lines Patch % Lines
vyper/venom/function.py 16.66% 10 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #4484      +/-   ##
==========================================
- Coverage   92.09%   92.04%   -0.06%     
==========================================
  Files         120      120              
  Lines       17349    17361      +12     
  Branches     2935     2940       +5     
==========================================
+ Hits        15978    15980       +2     
- Misses        954      964      +10     
  Partials      417      417              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants