Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add docs for c51.py and c51_atari.py #159

Merged
merged 10 commits into from
Apr 20, 2022
Merged

Add docs for c51.py and c51_atari.py #159

merged 10 commits into from
Apr 20, 2022

Conversation

vwxyzjn
Copy link
Owner

@vwxyzjn vwxyzjn commented Apr 11, 2022

Description

Types of changes

  • Bug fix
  • New feature
  • New algorithm
  • Documentation

Checklist:

  • I've read the CONTRIBUTION guide (required).
  • I have ensured pre-commit run --all-files passes (required).
  • I have updated the documentation and previewed the changes via mkdocs serve.
  • I have updated the tests accordingly (if applicable).

If you are adding new algorithms or your change could result in performance difference, you may need to (re-)run tracked experiments. See #137 as an example PR.

  • I have contacted @vwxyzjn to obtain access to the openrlbenchmark W&B team (required).
  • I have tracked applicable experiments in openrlbenchmark/cleanrl with --capture-video flag toggled on (required).
  • I have added additional documentation and previewed the changes via mkdocs serve.
    • I have explained note-worthy implementation details.
    • I have explained the logged metrics.
    • I have added links to the original paper and related papers (if applicable).
    • I have added links to the PR related to the algorithm.
    • I have created a table comparing my results against those from reputable sources (i.e., the original paper or other reference implementation).
    • I have added the learning curves (in PNG format with width=500 and height=300).
    • I have added links to the tracked experiments.
  • I have updated the tests accordingly (if applicable).

@vercel
Copy link

vercel bot commented Apr 11, 2022

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/vwxyzjn/cleanrl/8D1iKzsfwBQ12Lmuik14XUr1JnQB
✅ Preview: https://cleanrl-git-c51-docs-vwxyzjn.vercel.app

@gitpod-io
Copy link

gitpod-io bot commented Apr 11, 2022

@vwxyzjn
Copy link
Owner Author

vwxyzjn commented Apr 12, 2022

This branch is ready for review.

@vwxyzjn vwxyzjn mentioned this pull request Apr 16, 2022
10 tasks
@vwxyzjn vwxyzjn changed the title Add docs for c51_atari.py Add docs for c51.py and c51_atari.py Apr 16, 2022
Copy link
Collaborator

@dosssman dosssman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hello here.
Sorry for the late review.

Beside the few single comments, it looks quite good to me.
Great job as always.

@vwxyzjn
Copy link
Owner Author

vwxyzjn commented Apr 20, 2022

Thank you! Please approve the PR if everything looks good to you :)

@dosssman dosssman self-requested a review April 20, 2022 03:06
@vwxyzjn vwxyzjn merged commit dba4659 into master Apr 20, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants