Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make seed work again in value methods #134

Merged
merged 3 commits into from
Mar 11, 2022
Merged

Make seed work again in value methods #134

merged 3 commits into from
Mar 11, 2022

Conversation

vwxyzjn
Copy link
Owner

@vwxyzjn vwxyzjn commented Mar 9, 2022

Closes #133. Here is a demo for the fix:

asciicast

@gitpod-io
Copy link

gitpod-io bot commented Mar 9, 2022

@vercel
Copy link

vercel bot commented Mar 9, 2022

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/vwxyzjn/cleanrl/HQ3DhxkWKEVuefvyzPzsaxGXx5tw
✅ Preview: https://cleanrl-git-fix-dqn-seed-vwxyzjn.vercel.app

@vwxyzjn
Copy link
Owner Author

vwxyzjn commented Mar 11, 2022

Merging now.

@vwxyzjn vwxyzjn merged commit 4c8851c into master Mar 11, 2022
@vwxyzjn vwxyzjn deleted the fix-dqn-seed branch March 11, 2022 20:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

dqn.py does not respect seed
1 participant