Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: add .json linting in api-generator #18255

Merged
merged 3 commits into from
Dec 11, 2023
Merged

chore: add .json linting in api-generator #18255

merged 3 commits into from
Dec 11, 2023

Conversation

jacekkarczmarczyk
Copy link
Member

Description

lints locale/*.json files

MajesticPotatoe
MajesticPotatoe reviewed Sep 13, 2023
View reviewed changes
Copy link
Member

@MajesticPotatoe MajesticPotatoe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ran from root and local, seems to work as intended. may want @KaelWD to glance it real quick though

@johnleider johnleider requested a review from KaelWD September 25, 2023 14:53
@MajesticPotatoe MajesticPotatoe force-pushed the master branch 3 times, most recently from 7ce7b02 to 1adfeaa Compare October 12, 2023 13:13
johnleider
johnleider previously approved these changes Oct 16, 2023
View reviewed changes
@johnleider johnleider added this to the v3.3.x milestone Oct 16, 2023
@MajesticPotatoe MajesticPotatoe force-pushed the master branch 2 times, most recently from bb07313 to e5c1c07 Compare October 20, 2023 01:52
@KaelWD KaelWD modified the milestones: v3.3.x, v3.4.x Nov 3, 2023
@johnleider johnleider self-requested a review December 6, 2023 19:57
@johnleider
Copy link
Member

I'm working on resolving the conflicts but I'm confused at these script changes. Some seem necessary, some do not. Could you double check them @jacekkarczmarczyk ?

image

@jacekkarczmarczyk
Copy link
Member Author

The only change on my side in conflicting files was adding .json extension here https://github.com/vuetifyjs/vuetify/pull/18255/files#diff-e2954b558f2aa82baff0e30964490d12942e0e251c1aa56c3294de6ec67b7cf5R9 and here https://github.com/vuetifyjs/vuetify/pull/18255/files#diff-d336fff16d12cd7a5933093f2dd9b30552f11c8cd6f4910fbff46a64f1f8e499R10, and for me they seem to necessary, otherwise json files won't be processed (unless something changed in the meantime)

johnleider
johnleider previously approved these changes Dec 11, 2023
View reviewed changes
@johnleider johnleider merged commit f84800d into vuetifyjs:master Dec 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MajesticPotatoe MajesticPotatoe MajesticPotatoe left review comments

@johnleider johnleider johnleider left review comments

@KaelWD KaelWD Awaiting requested review from KaelWD

Assignees

@jacekkarczmarczyk jacekkarczmarczyk

Labels
T: api-generator
Projects
None yet
Milestone
v3.4.x
Development

Successfully merging this pull request may close these issues.
4 participants
@jacekkarczmarczyk @johnleider @MajesticPotatoe @KaelWD