Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

perf: add extractCSS #6301

Closed
wants to merge 2 commits into from
Closed

perf: add extractCSS #6301

wants to merge 2 commits into from

Conversation

Baroshem
Copy link
Contributor

Description

Related Issue

Motivation and Context

How Has This Been Tested?

Screenshots:

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • I have read the CONTRIBUTING document.

Changelog

  • I have updated the Changelog (V1) v2 and mentioned all breaking changes in the public API.
  • I have documented all new public APIs and made changes to existing docs mentioning the parts I've changed so they're up to date.

Tests

  • I have written test cases for my code
  • I have tested my Pull Request on production build and (to my knowledge) it works without any issues
  • I have added tests to cover my changes.
  • All new and existing tests passed.

I tested manually my code, and it works well with both:

  • Default Theme
  • Capybara Theme

Code standards

  • My code follows the code style of this project.

Docs

  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.

Baroshem and others added 2 commits September 13, 2021 07:53
@Baroshem @AdamPawlinski
@vn-vlad @igorwojciechowski @lukaszjedrasik @andrzejewsky @filipsobol @bloodf @filrak @youanden @jaydubb12 @Razz21 @lukasborawski @mkoszut @dawid-ziobro @lsliwaradioluz @lsliwa
feat: sync lighthouse next with develop (#6294)
7ef731b 
* fix: add modal to home page

* feat: add working newsletter modal

* fix: move newsletter  modal to core

* chore: add changelog info

* fix: styles

* enable summary section in desktop view

* fix payment template

* changelog added

* fx: changes after CR

* fix: add i18n for boilerplate

* fix: lint and i18n interpolation

* fix: remove console

* test: Extend happy path e2e test for registered customer

  + Update templates with 'v-e2e' directive

* fix: remove mobile observer causing infinite loop error

* fix: change email submit event name

* tests(e2e): add e2e tests for MyAccount

  + add v-e2e directives to ProfileUpdateForm.vue

* tests(e2e): add e2e tests for MyAccount

* tests(e2e): add email assertion on Change Password tab

* tests(e2e): fix code formatting

* fix: redirect to 404 page when category page does not exist

* update

* fix(core): add debounce for updateCartQuantity

* Sync `next` with `release/next` (#6236)

* Remove old commands and fix core tests (#6097)

* remove unused checkoutGetters

* update changelog

* Update packages/core/docs/changelog/5891.js

Co-authored-by: Filip Sobol <filipsobol@users.noreply.github.com>

* Update packages/core/docs/changelog/5891.js

Co-authored-by: Filip Sobol <filipsobol@users.noreply.github.com>

* Update packages/core/docs/changelog/5891.js

Co-authored-by: Filip Sobol <filipsobol@users.noreply.github.com>

* fix: remove 'download all' button

* update changelog

* chore: adds the stale-bot (#6247)

* chore: adds the stale-bot

* Update .github/stale.yml

Co-authored-by: Filip Rakowski <f.rakowskI@hotmail.com>

Co-authored-by: Filip Rakowski <f.rakowskI@hotmail.com>

* feat: add Vendure template beta to cli

* Fix typo (#5792)

integartions... => integrations...

* Bug/6099 missing dependency (#6100)

* bug/6089-incorrect-method --> resolved

* bug/6089-incorrect-method --> commit changelog

* bug/6099-missing-dependency

* bug/6099-missing-dependency -changelog

* Delete 6089.js

Co-authored-by: jason.wolf <jason.wolf@borngroup.com>
Co-authored-by: Heitor Ramon Ribeiro <heitor.ramon@gmail.com>

* Sync `next` with `release/next` (#6262)

* Sync `develop` with `release-2.4` (#6270)

* fix: address house number field mapping

* Sync `release-2.4` with `release/next` (#6237)

* Sync `release-2.4` with `release/next` (#6263)

* Sync `release-2.4` with `release/next` (#6269)

* Update the docs after 2.4 release (#6217)

* Remove CLI preview image, because it's outdated (#6223)

* [Docs] Update Integrations page and optimize SVG logos (#6220)

* [Docs] Add "Added in 1.3" badges to useForgotPassword and useStore in commercetools

* [Docs] Add Odoo to Integrations page (#6224)

* Export missing methods for api-extractor

* Add api-extractor-data file

* Update Vendure maintainers (#6230)

* Fix typings generation, update API references and CT Composables pages (#6235)

* Fix docs build (#6238)

* Docs grammar and typos check (#6064)

* Update Integrations page (#6244)

* [Docs] Reorganize docs into smaller categories (#6243)

* [Docs] Disable prefetching (#6255)

* Fix `labeler` for docs (#6256)

* feat: update Vendure integration status to beta

* Update maintainers of SFCC integration (#6259)

* Optimize homepage diagram (#6260)

* Use Node v12.22.4 for deployment

* Update Dockerfile

* Update

* Update

* Revert

* Update

* [Docs] Add "Extending Vue Storefront" and "Extending integrations" pages (#6252)

Co-authored-by: Lukas Borawski <lukas.borawski@gmail.com>
Co-authored-by: ljedrasik <ljedrasik@vuestorefront.io>
Co-authored-by: igorwojciechowski <igorxwojciechowski@gmail.com>
Co-authored-by: Baroshem <jakub.andrzejewski.dev@gmail.com>
Co-authored-by: Jakub Andrzejewski <37120330+Baroshem@users.noreply.github.com>
Co-authored-by: mkoszut <mkoszut@gmail.com>

* Update deps

Co-authored-by: Razz21 <razzrazz@wp.pl>
Co-authored-by: Patryk Andrzejewski <vox3r69@gmail.com>
Co-authored-by: Lukas Borawski <lukas.borawski@gmail.com>
Co-authored-by: ljedrasik <ljedrasik@vuestorefront.io>
Co-authored-by: igorwojciechowski <igorxwojciechowski@gmail.com>
Co-authored-by: Baroshem <jakub.andrzejewski.dev@gmail.com>
Co-authored-by: Jakub Andrzejewski <37120330+Baroshem@users.noreply.github.com>
Co-authored-by: mkoszut <mkoszut@gmail.com>

* [FIX]: Search products by skus error (#6182)

* fix: nullable where getProduct graphql param

* fix: unit-test

* chore: add changelog

* Update packages/core/docs/commercetools/changelog/6181.js

Co-authored-by: Filip Sobol <filipsobol@users.noreply.github.com>

Co-authored-by: Filip Sobol <filipsobol@users.noreply.github.com>

* chore: added missing PR title validation action (#6274)

* chore: added missing PR title validation action

* chore: temporarily removed @commitlint/config-lerna-scopes

the packages were removed due to the lerna structure not being fully complete structured correctly.

* fix(ct): fix no property error in useUser/changePassword (#6232)

* fix(ct): fix no property error in useUser/changePassword

* fix(ct/core): change `logOut` signature

 ~ Change `params` to optional in `useUserFactory`
 - Remove redundant param from `logOut` in commercetools theme

* [OS-71]: Product :: Color filter param set to object, not color value (#6251)

* fix: PDP color filter value

* chore: changelog

* feat: sync develop with release 2.4 (#6278)

* fix: address house number field mapping

* Sync `release-2.4` with `release/next` (#6237)

* Sync `release-2.4` with `release/next` (#6263)

* Sync `release-2.4` with `release/next` (#6269)

* Update the docs after 2.4 release (#6217)

* Remove CLI preview image, because it's outdated (#6223)

* [Docs] Update Integrations page and optimize SVG logos (#6220)

* [Docs] Add "Added in 1.3" badges to useForgotPassword and useStore in commercetools

* [Docs] Add Odoo to Integrations page (#6224)

* Export missing methods for api-extractor

* Add api-extractor-data file

* Update Vendure maintainers (#6230)

* Fix typings generation, update API references and CT Composables pages (#6235)

* Fix docs build (#6238)

* Docs grammar and typos check (#6064)

* Update Integrations page (#6244)

* [Docs] Reorganize docs into smaller categories (#6243)

* [Docs] Disable prefetching (#6255)

* Fix `labeler` for docs (#6256)

* feat: update Vendure integration status to beta

* Update maintainers of SFCC integration (#6259)

* Optimize homepage diagram (#6260)

* Use Node v12.22.4 for deployment

* Update Dockerfile

* Update

* Update

* Revert

* Update

* [Docs] Add "Extending Vue Storefront" and "Extending integrations" pages (#6252)

Co-authored-by: Lukas Borawski <lukas.borawski@gmail.com>
Co-authored-by: ljedrasik <ljedrasik@vuestorefront.io>
Co-authored-by: igorwojciechowski <igorxwojciechowski@gmail.com>
Co-authored-by: Baroshem <jakub.andrzejewski.dev@gmail.com>
Co-authored-by: Jakub Andrzejewski <37120330+Baroshem@users.noreply.github.com>
Co-authored-by: mkoszut <mkoszut@gmail.com>

* Fix loading user and cart information (#6265)

* Fix loading user and cart information

* Add changelogs

* tests(e2e): fix tests data and selectors (#6277)

* tests(e2e): fix my-account tests after sync

Co-authored-by: Razz21 <razzrazz@wp.pl>
Co-authored-by: Patryk Andrzejewski <vox3r69@gmail.com>
Co-authored-by: Filip Sobol <filipsobol@users.noreply.github.com>
Co-authored-by: Lukas Borawski <lukas.borawski@gmail.com>
Co-authored-by: ljedrasik <ljedrasik@vuestorefront.io>
Co-authored-by: Baroshem <jakub.andrzejewski.dev@gmail.com>
Co-authored-by: Jakub Andrzejewski <37120330+Baroshem@users.noreply.github.com>
Co-authored-by: mkoszut <mkoszut@gmail.com>

* chore(e2e): fix start command in regression workflow (#6280)

* test(os-159): added e2e tests for breadcrumbs (#6267)

* Sync `release-2.4` with `release/next` (#6237)

* test(os-159): added e2e tests for breadcrumbs on category page

* Update packages/commercetools/theme/tests/e2e/integration/e2e-breadcrumbs.spec.ts

* fix(ct): add missing order summary data (#6283)

* fix(ct): add missing order summary data

* chore: add changelog for #6282

* tests(core): fix jest config for middleware (#6289)

* [EN-284]: Not all queries in commercetools are wrapped in `gql` template literal (#6058)

* chore: Add gql wrapper to queries where missing

* Make CT tests happy

* Remove redundant unmock call from tests

Co-authored-by: Łukasz <lukasz.sliwa@newfantastic.com>

* test(e2e): add addresses tests on order summary (#6291)

* test(e2e): add order summary addresses validation tests

* refactor(e2e): refactor order summary tests

* test(e2e): refactor cypress tags

* Ci/configure lighthouse (#6206)

* ci: configure lighthouse

* ci: adjust lighthouse workflow

* chore: fix branch names in ci test workflow (#6292)

* fix(ct): add missing pagination for orders history (#6290)

* fix(commercetools): add missing orders pagination

* chore: add changelog

* fix(ct): fix sorting

* fix(core): remove unused methods

Co-authored-by: AdamPawlinski <apawlinski@vuestorefront.io>
Co-authored-by: v.vlad <vladyslav.vakhnovskyi@spryker.com>
Co-authored-by: Igor Wojciechowski <igorxwojciechowski@gmail.com>
Co-authored-by: ljedrasik <ljedrasik@vuestorefront.io>
Co-authored-by: Patryk Andrzejewski <vox3r69@gmail.com>
Co-authored-by: Filip Sobol <filipsobol@users.noreply.github.com>
Co-authored-by: Heitor Ramon Ribeiro <heitor.ramon@gmail.com>
Co-authored-by: Filip Rakowski <f.rakowskI@hotmail.com>
Co-authored-by: Georgiy Slobodenyuk <georgiy@absoluteweb.com>
Co-authored-by: Jason Wolf <jaydubb12@gmail.com>
Co-authored-by: jason.wolf <jason.wolf@borngroup.com>
Co-authored-by: Razz21 <razzrazz@wp.pl>
Co-authored-by: Lukas Borawski <lukas.borawski@gmail.com>
Co-authored-by: mkoszut <mkoszut@gmail.com>
Co-authored-by: Andrzej K <32792205+Razz21@users.noreply.github.com>
Co-authored-by: daaf <44862757+dawid-ziobro@users.noreply.github.com>
Co-authored-by: lsliwaradioluz <39009379+lsliwaradioluz@users.noreply.github.com>
Co-authored-by: Łukasz <lukasz.sliwa@newfantastic.com>
@Baroshem
perf: add extractCSS
4f8ed88
@github-actions github-actions bot added commercetools Next Issues/bugs for Vue Storefront Next labels Sep 13, 2021
@Baroshem Baroshem added performance Issues related to improving performance of VSF and removed Next Issues/bugs for Vue Storefront Next commercetools labels Sep 13, 2021
@Baroshem Baroshem mentioned this pull request Sep 14, 2021
Closed
1 task
@Baroshem Baroshem changed the base branch from lighthouse/next to develop September 29, 2021 07:09
@Baroshem Baroshem mentioned this pull request Sep 29, 2021
Merged
16 tasks
@Baroshem
Copy link
Contributor Author

Closing in favor of #6377

@Baroshem Baroshem closed this Sep 29, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bloodf bloodf bloodf approved these changes

@dawid-ziobro dawid-ziobro dawid-ziobro approved these changes

Assignees
No one assigned
Labels
performance Issues related to improving performance of VSF
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Baroshem @bloodf @dawid-ziobro