feat: #49 (theme) remove unnecessary code

vuestorefront-community · Aug 22, 2021 · 9a9b46a · 9a9b46a
1 parent 423c6e6
commit 9a9b46a
Show file tree

Hide file tree

Showing 2 changed files with 8 additions and 26 deletions.
diff --git a/packages/theme/components/Checkout/CartPreview.vue b/packages/theme/components/Checkout/CartPreview.vue
@@ -73,7 +73,7 @@ import {
   SfInput,
   SfCircleIcon
 } from '@storefront-ui/vue';
-import { computed, ref, watch } from '@vue/composition-api';
+import { computed, ref } from '@vue/composition-api';
 import { useCart, cartGetters } from '@vue-storefront/vendure';
 import { getCalculatedPrice } from '~/helpers';
 
@@ -88,14 +88,8 @@ export default {
     SfInput,
     SfCircleIcon
   },
-  props: {
-    selectedShippingMethod: {
-      type: Object,
-      required: false
-    }
-  },
-  setup (props) {
-    const { cart, removeItem, updateItemQty, applyCoupon, load } = useCart();
+  setup () {
+    const { cart, removeItem, updateItemQty, applyCoupon } = useCart();
 
     const listIsHidden = ref(false);
     const promoCode = ref('');
@@ -107,10 +101,6 @@ export default {
     const discounts = computed(() => cartGetters.getDiscounts(cart.value));
     const shippingCost = computed(() => getCalculatedPrice(cart?.value?.shipping));
 
-    watch(() => props.selectedShippingMethod, async () => {
-      await load();
-    });
-
     return {
       discounts,
       totalItems,
@@ -144,8 +134,7 @@ export default {
 
       shippingCost,
       hasSpecialPrice: computed(() => totals.value.special > 0 && totals.value.special < totals.value.subtotal),
-      getCalculatedPrice,
-      cart
+      getCalculatedPrice
     };
   }
 };

diff --git a/packages/theme/pages/Checkout.vue b/packages/theme/pages/Checkout.vue
@@ -13,7 +13,7 @@
             :key="key"
             :name="step"
           >
-            <nuxt-child @shippingMethodSelected="updateShippingInCartPreview"/>
+            <nuxt-child />
           </SfStep>
         </SfSteps>
         <nuxt-child v-else />
@@ -23,7 +23,7 @@
         class="checkout__aside desktop-only"
       >
         <transition name="fade">
-          <CartPreview key="order-summary" :selectedShippingMethod="selectedShippingMethod" />
+          <CartPreview key="order-summary" />
         </transition>
       </div>
     </div>
@@ -33,7 +33,7 @@
 
 import { SfSteps, SfButton } from '@storefront-ui/vue';
 import CartPreview from '~/components/Checkout/CartPreview';
-import { computed, ref } from '@vue/composition-api';
+import { computed } from '@vue/composition-api';
 
 const STEPS = {
   shipping: 'Shipping',
@@ -52,25 +52,18 @@ export default {
     const currentStep = computed(() => context.root.$route.path.split('/').pop());
     const currentStepIndex = computed(() => Object.keys(STEPS).findIndex(s => s === currentStep.value));
     const isThankYou = computed(() => currentStep.value === 'thank-you');
-    const selectedShippingMethod = ref(null);
 
     const handleStepClick = (stepIndex) => {
       const key = Object.keys(STEPS)[stepIndex];
       context.root.$router.push(`/checkout/${key}`);
     };
 
-    const updateShippingInCartPreview = (shippingMethod) => {
-      selectedShippingMethod.value = shippingMethod;
-    };
-
     return {
       handleStepClick,
       STEPS,
       currentStepIndex,
       isThankYou,
-      currentStep,
-      updateShippingInCartPreview,
-      selectedShippingMethod
+      currentStep
     };
   }
 };