Skip to content
This repository has been archived by the owner on May 13, 2024. It is now read-only.

fix: cannot click tag labels on outside of the text (fix #84) #85

Merged
merged 2 commits into from
Jun 9, 2020

Conversation

twitwi
Copy link
Contributor

@twitwi twitwi commented Jun 1, 2020

fixes #84

The diff is huge, mainly due to additionnal nesting (causing more indent in the style).

Summary

What kind of change does this PR introduce? (check at least one)

  • Bugfix
  • Feature
  • Code style update
  • Refactor
  • Docs
  • Build-related changes
  • Other, please describe:

If changing the UI of default theme, please provide the before/after screenshot:

Does this PR introduce a breaking change? (check one)

  • Yes
  • No

If yes, please describe the impact and migration path for existing applications:

The PR fulfills these requirements:

  • When resolving a specific issue, it's referenced in the PR's title (e.g. fix #xxx[,#xxx], where "xxx" is the issue number)

You have tested in the following browsers: (Providing a detailed version will be better.)

  • Chrome
  • Firefox
  • Safari
  • Edge
  • IE

If adding a new feature, the PR's description includes:

  • A convincing reason for adding this feature
  • Related documents have been updated
  • Related tests have been updated

To avoid wasting your time, it's best to open a feature request issue first and wait for approval before working on it.

Other information:

fixes vuepress#84

The diff is huge, mainly due to additionnal nesting (causing more indent in the style).
@twitwi twitwi changed the title Clickable tag labels (incl. outside of the text) Clickable tag labels (incl. outside of the text), fix #84 Jun 1, 2020
Copy link
Member

@billyyyyy3320 billyyyyy3320 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@billyyyyy3320 billyyyyy3320 changed the title Clickable tag labels (incl. outside of the text), fix #84 fix: cannot click tag labels on outside of the text (fix #84) Jun 9, 2020
@billyyyyy3320 billyyyyy3320 merged commit 4ae4231 into vuepress:master Jun 9, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Cannot click tag labels (on part of the tag without text)
2 participants