-
-
Notifications
You must be signed in to change notification settings - Fork 340
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: allow firebase-admin
v12
#1473
Conversation
Thanks! It looks like firebase-functions are still not supporting firebase-admin 12, so we will have to wait a bit longer. I pushed changes to actually change the peer dep (it wasn't changed) |
Codecov ReportAll modified and coverable lines are covered by tests ✅
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## main #1473 +/- ##
=======================================
Coverage 75.93% 75.93%
=======================================
Files 21 21
Lines 3387 3387
Branches 263 263
=======================================
Hits 2572 2572
Misses 815 815 ☔ View full report in Codecov by Sentry. |
Oops, missed that! Thanks :) |
It looks like there is a PR tracking this: firebase/firebase-functions#1496 |
Thanks for the PR. I will locally update once the upstream issue is fixed. |
@posva it was merged a few hours after you closed this :D any update on this fix? |
@posva Is there any chance this could be looked at again please? |
The Firebase Admin SDK for Node has been bumped to v12. This currently leads to unmet peer dependency warnings:
This PR adds v12 to the allowed ranges.