Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(cleanUrls): CleanUrls feature - No .html in navigation bar #488

Closed
wants to merge 3 commits into from

Conversation

georges-gomes
Copy link
Collaborator

This feature is meant to be working with SPA and MPA mode so it's a little bit bigger than just rename the browser location.

  • New option: cleanUrls (default false)
  • Generates /foo.md -> /foo/index.html (This works best for MPA mode with most static site hosting services)
  • Internal links in .md files are not transformed to .html
  • When on SPA mode, the client router doesn't rename /foo into /foo.html anymore.

First PR on Vitepress so please send comments, I will adjust.

@georges-gomes
Copy link
Collaborator Author

Fixes #219

@georges-gomes georges-gomes requested a review from yyx990803 March 24, 2022 15:44
@georges-gomes
Copy link
Collaborator Author

Hi @kiaking
Since you seem to be working for "next" release.
Do you want this PR for it?
I have the feeling this is an important feature for some people.
(including me obviously)
Let me know what should be done.
Thanks

@kiaking
Copy link
Member

kiaking commented May 23, 2022

@georges-gomes Yes! That would be super cool 🙌 I think this is a nice feature to have 👍

@georges-gomes
Copy link
Collaborator Author

@kiaking should I try to rebase on next branch?

@kiaking
Copy link
Member

kiaking commented May 23, 2022

Yes please! Let's see if it works. No change in theme file, so it might just work fine 👀

@azat-io
Copy link
Contributor

azat-io commented Jun 15, 2022

Really looking forward to this feature

@georges-gomes
Copy link
Collaborator Author

Replaced by #869

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jan 21, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants