You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
We should add an aria-label to the headings. Currently with aria-label not specified, VoiceOver returns heading level 1, 2 items What is VitePress, visited, link, Permalink to "What is VitePress?", which is very unclear and verbose.
I am willing to fix this bug by myself. However as I'm not familiar with MarkdownIt, I think I need some help on where to customize the rendering rules of headers.
BREAKING CHANGES:
- `--vp-header-anchor-symbol` is removed
- The default permalink function of markdown-it-anchor is changed to `linkAfterHeader`. This will need updates in your custom themes.
This brings the original proposed behavior of #2039, #2040 which wasn't introduced to avoid breaking changes.
fixes#2980closes#2982
Describe the bug
We should add an aria-label to the headings. Currently with aria-label not specified, VoiceOver returns
heading level 1, 2 items What is VitePress, visited, link, Permalink to "What is VitePress?"
, which is very unclear and verbose.Reproduction
Just head to https://vitepress.dev/guide/what-is-vitepress on Mac, open VoiceOver and click on any heading.
Expected behavior
An aria-label should be added to heading elements. Take the
# What is VitePress?
as an example, it should be rendered as:Then VoiceOver returns
Heading level 1, What is VitePress?
.System Info
Additional context
I am willing to fix this bug by myself. However as I'm not familiar with MarkdownIt, I think I need some help on where to customize the rendering rules of headers.
Validations
The text was updated successfully, but these errors were encountered: