Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: upgrade to Prettier 3 #2467

Merged
merged 1 commit into from
Feb 27, 2025
Merged

chore: upgrade to Prettier 3 #2467

merged 1 commit into from
Feb 27, 2025

Conversation

skirtles-code
Copy link
Contributor

Apart from package.json and pnpm-lock.yaml, all the changes come from running lint:fix.

Prettier 2 doesn't support using with { type: 'json' } for imports, which we're using in some .mjs files. Currently we aren't linting .mjs files, but that's something I'd eventually like to change. Upgrading Prettier is a first step towards that.

Copy link

netlify bot commented Feb 26, 2025

Deploy Preview for vue-router canceled.

Name Link
🔨 Latest commit 48327b6
🔍 Latest deploy log https://app.netlify.com/sites/vue-router/deploys/67bf5011126fc10008d61178

Copy link

pkg-pr-new bot commented Feb 26, 2025

Open in Stackblitz

npm i https://pkg.pr.new/vue-router@2467

commit: 48327b6

Copy link

codecov bot commented Feb 26, 2025

Codecov Report

Attention: Patch coverage is 84.21053% with 6 lines in your changes missing coverage. Please review.

Project coverage is 94.89%. Comparing base (1ad847e) to head (48327b6).
Report is 2 commits behind head on main.

Files with missing lines Patch % Lines
packages/router/src/navigationGuards.ts 86.66% 4 Missing ⚠️
packages/router/src/location.ts 50.00% 1 Missing ⚠️
packages/router/src/query.ts 50.00% 1 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##             main    #2467   +/-   ##
=======================================
  Coverage   94.88%   94.89%           
=======================================
  Files          34       34           
  Lines        2993     2998    +5     
  Branches      845      845           
=======================================
+ Hits         2840     2845    +5     
  Misses        150      150           
  Partials        3        3           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@posva posva left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot!

@posva
Copy link
Member

posva commented Feb 27, 2025

In the next version we will likely upgrade to use type: module as well. The json import can always be rewritten as a read file + JSON.parse

@posva posva merged commit 3753ede into vuejs:main Feb 27, 2025
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants