Skip to content

fix(runtime-dom): inconsistent behaviour on nested transition groups #8803

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 8 commits into
base: main
Choose a base branch
from
Open

fix(runtime-dom): inconsistent behaviour on nested transition groups #8803

Changes from 1 commit
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
60f3886
fix(runtime-dom): inconsistent behaviour on nested transition groups …
Jul 18, 2023
4da6b29
refactor(runtime-dom): use simple Position object instead of DOMRect …
Jun 13, 2024
3abe763
Merge branch 'main' into fix/nested-transitiongroup
Jun 24, 2024
f3ea4b8
Merge branch 'main' into fix/nested-transitiongroup
daniser Jul 8, 2024
dcc93a8
Merge branch 'main' into fix/nested-transitiongroup
edison1105 Aug 20, 2024
ff6a6b0
Merge branch 'vuejs:main' into fix/nested-transitiongroup
daniser Sep 16, 2024
29a1647
Merge branch 'main' into fix/nested-transitiongroup
edison1105 Nov 4, 2024
83895e7
Merge branch 'vuejs:main' into fix/nested-transitiongroup
daniser Nov 22, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
20 changes: 18 additions & 2 deletions packages/runtime-dom/src/components/TransitionGroup.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -132,7 +132,10 @@ const TransitionGroupImpl: ComponentOptions = {
child,
resolveTransitionHooks(child, cssTransitionProps, state, instance)
)
positionMap.set(child, (child.el as Element).getBoundingClientRect())
positionMap.set(
child,
getRelativeBoundingClientRect(child.el as Element)
)
}
}

Expand Down Expand Up @@ -170,8 +173,21 @@ function callPendingCbs(c: VNode) {
}
}

function getRelativeBoundingClientRect(el: Element) {
const elRect = el.getBoundingClientRect()
if (!el.parentElement) return elRect
const parentRect = el.parentElement.getBoundingClientRect()

return new DOMRectReadOnly(
elRect.x - parentRect.x,
elRect.y - parentRect.y,
elRect.width - parentRect.width,
elRect.height - parentRect.height
)
}

function recordPosition(c: VNode) {
newPositionMap.set(c, (c.el as Element).getBoundingClientRect())
newPositionMap.set(c, getRelativeBoundingClientRect(c.el as Element))
}

function applyTranslation(c: VNode): VNode | undefined {
Expand Down