Fixes the dcdr-js client's file watcher #4
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I discovered that the
dcdr-js
client was not responding to any changes made to the underlying decider.json file. The client was using node'sfs.watch
to implement its file watching capability, but turns outfs.watch
is notoriously buggy. I've replacedfs.watch
with the chokidar library (note this library used by many of the js build systems out there), which is a wrapper around thefs.watch
but fixes its shortcomings. I've also written a unit test to cover file watching functionality.