Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Drop EoL module support #156

Merged
merged 3 commits into from
Aug 22, 2023
Merged

Drop EoL module support #156

merged 3 commits into from
Aug 22, 2023

Conversation

bastelfreak
Copy link
Member

This is a requirement to update the module dependencies. The dependencies don't support such ancient operating systems.

also contains:

This is a requirement to update the module dependencies. The
dependencies don't support such ancient operating systems.
@ju5t
Copy link
Contributor

ju5t commented Aug 22, 2023

Thanks for all the PR's! Is there any order in which they should be merged? Because some changes are in different PR's as well. Also wondering if we're not disabling too many Rubocop checks.

@bastelfreak
Copy link
Member Author

Every branch is built on top of each other. #151 is the latest. When you merge that, all other PRs will be marked as merged as well. But you can also merge them in a random order.

I'm also not a big fan of this particular rubocop config, but it's the default from pdk update: https://github.com/puppetlabs/pdk-templates/blob/main/config_defaults.yml#L66-L486

@ju5t ju5t merged commit fbba61f into voxpupuli:main Aug 22, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants