Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support Sensitive strings #148

Merged
merged 3 commits into from
Mar 31, 2023
Merged

Support Sensitive strings #148

merged 3 commits into from
Mar 31, 2023

Conversation

deric
Copy link
Contributor

@deric deric commented Mar 14, 2023

This PR adds support secrets passed as Sensitive data type.

deric added 2 commits March 14, 2023 20:57
> Your RubyGems version (3.0.3.1) has a bug that prevents `required_ruby_version` from working for Bundler
@ju5t
Copy link
Contributor

ju5t commented Mar 30, 2023

@deric thanks for the PR! And sorry for the late reply. I have a few questions.

  1. Could you add some details to the docs about this feature?
  2. I think ldap_secret is missing an unwrap, or am I missing something?
  3. What is the difference between a secret and a configvalue? The configvalue doesn't seem to be used?

@deric
Copy link
Contributor Author

deric commented Mar 30, 2023

@ju5t

  1. Sure, there's not much to document. Sensitive type passwords aren't printed in logs like plain-text password and passwords are stored in git as encrypted strings.
  2. Yes, you're right. Sorry, I've overlooked that.
  3. Powerdns::ConfigValue allows empty strings, integers, secrets, etc. while Powerdns::Secret is strictly non-empty string or Sensitive type

@ju5t
Copy link
Contributor

ju5t commented Mar 30, 2023

@deric regarding the documentation, it helps if people know how to use this. Or perhaps, it should even be the default in our documentation. As it's a safer option. It's an awesome feature.

About ConfigValue's. I overlooked it's use, sorry.

@deric
Copy link
Contributor Author

deric commented Mar 30, 2023

@ju5t I've fixed unwrapping ldap_secret and updated the docs.

@ju5t ju5t merged commit 24d44fe into voxpupuli:main Mar 31, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants