Improve show puppetfile #273
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
table_print column width is miscomputed when ANSI escape sequences are used, leading to inconsistent alignments. Switch to terminal-table which handle these sequences gracefuly.
When running onceover show puppetfile multiple times, the ordering of lines is unpredictable, making it hard to compare successive runs. Sort lines by module fullname so that the modules ordering is predictible.
|
This looks great, will fix #182 also. I've re-kicked the appveyor tests as the error seems transient |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Improve the output of
onceover show puppetfile:Before:
After:
