Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support spec files selection before running tests #262

Merged
merged 2 commits into from
Jul 29, 2020
Merged

Support spec files selection before running tests #262

merged 2 commits into from
Jul 29, 2020

Conversation

neomilium
Copy link
Contributor

This PR is related to #261

Before this PR, using onceover when you have other traditional rspec spec tests may be a problem if you:

  • want/need a different rspec setup; or
  • want to have a different job in CI for onceover spec tests and traditional rspec tests

This PR provides a way to only include selected files from spec/ directory, before running onceover.

@neomilium
Copy link
Contributor Author

neomilium commented Mar 21, 2020 •
edited
Loading

This PR is fully functional but need a review to find a better option name, if relevant.

If @dylanratcliffe is interested in merging this PR, I'll improve README.md file to document the new config entry.

@neomilium neomilium mentioned this pull request Mar 21, 2020
Closed
@neomilium
Copy link
Contributor Author

Please note that travis checks failed due to a ruby 2.5 method usage. If you want to support obsolete ruby version (2.3 is EOL since 1 year and 2.4 will be at the end of this month), I can improve the PR.

@neomilium
Copy link
Contributor Author

@dylanratcliffe Have you looked to this PR?

@neomilium
Copy link
Contributor Author

@dylanratcliffe Hello, what about this PR?

@neomilium neomilium force-pushed the improve-specs-selection branch 2 times, most recently from fbc5944 to 6f24d7b Compare June 25, 2020 15:47
@neomilium
Copy link
Contributor Author

@dylanratcliffe I rebased my patch on top of your master.

smortex
smortex reviewed Jul 8, 2020
View reviewed changes
@neomilium neomilium changed the title WIP: Support spec files selection before running tests Support spec files selection before running tests Jul 10, 2020
@dylanratcliffe
Copy link
Collaborator

Hey sorry I've left this for so long. Yeah we need 2.4 to ensure Puppet 5 compatibility as @smortex mentioned. I like the functionality, but can I please get the option documented in the README? I'm happy to merge once that's done and the tests pass. I think it's another transient Appveyor error so I'll kick that off again now

dylanratcliffe
dylanratcliffe approved these changes Jul 13, 2020
View reviewed changes
Copy link
Collaborator

@dylanratcliffe dylanratcliffe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just needs README then we're good to merge

neomilium and others added 2 commits July 25, 2020 15:20
@neomilium
Support spec files selection before running tests
4767ebf
@neomilium @smortex
Fix Ruby 2.4 support
06d7fde 
Co-authored-by: Romain Tartière <romain@blogreen.org>
@neomilium neomilium force-pushed the improve-specs-selection branch from 6467d3e to 06d7fde Compare July 25, 2020 13:20
@neomilium
Copy link
Contributor Author

@dylanratcliffe Done!

@neomilium neomilium mentioned this pull request Jul 26, 2020
Merged
@smortex
Copy link
Member

smortex commented Jul 29, 2020

CI failure is unrelated to the change (transient failure).

@dylanratcliffe
Copy link
Collaborator

I'm re-running the failed tests and once they're green I'll merge

@dylanratcliffe dylanratcliffe merged commit e3e9b67 into voxpupuli:master Jul 29, 2020
@dylanratcliffe
Copy link
Collaborator

Releases in: https://github.com/dylanratcliffe/onceover/releases/tag/v3.18.0

@neomilium neomilium deleted the improve-specs-selection branch August 3, 2020 07:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@smortex smortex smortex approved these changes

@dylanratcliffe dylanratcliffe dylanratcliffe approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@neomilium @dylanratcliffe @smortex