Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

precondition pp files not escaped correctly when put into rspec-puppet precondition heredoc #224

Closed
alexjfisher opened this issue Jun 5, 2019 · 0 comments · Fixed by #230
Closed

precondition pp files not escaped correctly when put into rspec-puppet precondition heredoc #224

alexjfisher opened this issue Jun 5, 2019 · 0 comments · Fixed by #230
Labels
bug

Comments

@alexjfisher
Copy link
Member

eg The following in spec/pre_conditions/mock_site.pp does not work.

$role = regsubst($onceover_class, '^(role::)(.*)$', '\2')

The \ in '\2' needs escaping when written into the heredoc in .onceover/spec/classes/role__foo_on_CentOS-7_spec.rb
dylanratcliffe pushed a commit that referenced this issue Jun 10, 2019
Fixed escaping in pre_conditions
d73c7f8 
This means that backslashes will now be handles properly by Ruby.
Fixes #224
@dylanratcliffe dylanratcliffe mentioned this issue Jun 10, 2019
Merged
dylanratcliffe pushed a commit that referenced this issue Feb 8, 2020
(DOC) Fixed controlrepo reference (Fixes #224)
799b589
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fixed escaping in pre_conditions voxpupuli/onceover
2 participants
@alexjfisher @dylanratcliffe