Implement writing out a containerfile for a host #125
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #125 +/- ##
=======================================
Coverage 86.37% 86.37%
=======================================
Files 1 1
Lines 279 279
=======================================
Hits 241 241
Misses 38 38 ☔ View full report in Codecov by Sentry. |
This allows running:
beaker-docker containerfile centos9-64
The spec is ran through beaker-hostgenerator and then it writes to
Containerfile. The filename can also be passed in as an additional
argument.
ekohl
commented
Mar 9, 2024
|
|
||
| hypervisor = network_manager.hypervisors['docker'] | ||
| # TODO: private method | ||
| File.write(filename, hypervisor.send(:dockerfile_for, hosts.first)) |
There was a problem hiding this comment.
I considered alternatives like writing out multiple files if there are multiple hosts, but I decided to keep it simple for now.
jay7x
approved these changes
Mar 9, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This allows running:
The spec is ran through beaker-hostgenerator and then it writes to Containerfile. The filename can also be passed in as an additional argument.
This is an alternative to #124.