Modulo division performed in shuffle_deck once per card

voloved · Sep 8, 2024 · d72e167 · d72e167
1 parent f74419d
commit d72e167
Showing 1 changed file with 1 addition and 1 deletion.
diff --git a/movement/watch_faces/complication/higher_lower_game_face.c b/movement/watch_faces/complication/higher_lower_game_face.c
@@ -100,7 +100,7 @@ static void shuffle_deck(uint8_t *array, uint8_t n) {
     // Randomize shuffle with Fisher Yates
     uint8_t i, j, tmp;
      for (i = n - 1; i > 0; i--) {
-         j = generate_random_number(0xFF) % (i + 1);
+         j = generate_random_number(i + 1);
          tmp = array[j];
          array[j] = array[i];
          array[i] = tmp;