Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[2023.05.2-base] DL edition #285

Merged
merged 139 commits into from
May 24, 2023
Merged

[2023.05.2-base] DL edition #285

merged 139 commits into from
May 24, 2023

Conversation

AndreaVolkamer
Copy link
Member

@AndreaVolkamer AndreaVolkamer commented Dec 6, 2022

Description

TeachOpenCADD DL edition.

Comments from @dominiquesydow:

Todos

Questions

  • Question1

Status

  • Ready to go

@AndreaVolkamer AndreaVolkamer changed the title Starting PR for new DL edition [DL Edition] Base branch Dec 8, 2022
@dominiquesydow
Copy link
Collaborator

@AndreaVolkamer what is your current plan with this PR regarding the merge? First merging #345 and then this?

@dominiquesydow dominiquesydow added the work-in-progress Work still ongoing label May 11, 2023
@dominiquesydow dominiquesydow changed the title [DL Edition] Base branch [2023.05.2-base] DL edition May 15, 2023
@AndreaVolkamer
Copy link
Member Author

@dominiquesydow yes, we first merge the PR #345 to update the master branch, then we merge the new notebooks into it (this PR).

@mbackenkoehler mbackenkoehler changed the base branch from master to dev May 19, 2023 12:50
@mbackenkoehler
Copy link
Collaborator

I changed the target to dev. We can test out the environment and the merge in general before the DL_edition release.

@mbackenkoehler mbackenkoehler merged commit 7bc175b into dev May 24, 2023
@mbackenkoehler mbackenkoehler deleted the DL_edition branch May 24, 2023 13:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
2023.05.2 (DL edition) [tmp] All PRs for DL edition work-in-progress Work still ongoing
Projects
None yet
Development

Successfully merging this pull request may close these issues.

9 participants