Introduce 'vcd_external_network_v2' and dependencies with NSX-T support

[Didainius]

This PR introduces resource and data source vcd_external_network_v2 which is using new NSX-T capable OpenAPI.

Note. This resource requires API version of at least V33.0 (VCD 10.0+) to work.

The resource itself covers both NSX-V and NSX-T support as does the underlying API. Such improvements in comparison to vcd_external_network resource should be also there:

• It uses Terraform's TypeSet everywhere so issues (resource/vcd_external_network should use TypeSet instead of TypeList for ip_scope blocks #395, Issue while creating External Network with multiple IP Pools and Static IP Pools using dynamic block #503) currently present in vcd_external_network should not be here.
• Supports Update

The resource itself is very much similar to original vcd_external_network but has a few notable changes:

• ip_scope blocks use prefix_length instead of netmask (dictated by API itself)
• ip_scope blocks have optional enabled flag
• retain_net_info_across_deployments is not present in API therefore this resource does not expose it
• vsphere_network and nsxt_network blocks use ID references instead of names. For this purpose there are 4 new datasources:
  • vcd_vcenter
  • vcd_portgroup
  • vcd_nsxt_manager
  • vcd_nsxt_tier0_router

Additional testing functions introduced:

• testCheckMatchOutput allows to check output value by regexp
• testCheckOutputNonEmpty allows to check if output value is not empty

Notes:

• NSX-T backed networks do not support setting dns1, dns2 and dns_suffix fields therefore it is not supported and will throw error.
• vcd/sample_vcd_test_config.json has a few new fields required to cover NSX-T testing

[vbauzys]

First pass.

[vbauzys]

assigned or used in comments explaining the complexity you are using used.

[Didainius]

Yes, but used is somewhat "informal" for an attribute to me. We could probably discuss consumed if that sounds better.
cc @dataclouder, @lvirbalas

[vbauzys]

@dataclouder @lvirbalas your input still would be valuable

[dataclouder]

assigned is good

[lvirbalas]

is_assigned is fine for me in this context. BTW, it's TypeString ;)

[Didainius]

Will be TypeBool

[lvirbalas]

May the example be broken? I get these errors with it:

$ terraform apply

Error: Missing required argument

  on nsx-t.tf line 90, in resource "vcd_external_network_v2" "ext-net-nsxv":
  90:   ip_scope {

The argument "prefix_length" is required, but no definition was found.


Error: Unsupported argument

  on nsx-t.tf line 92, in resource "vcd_external_network_v2" "ext-net-nsxv":
  92:     netmask      = "24"

An argument named "netmask" is not expected here.

[Didainius]

Correct. Leftover from old example. Changed.

[lvirbalas]

In contrast to this "normal" Tier-0 router, where/when Terraform user should use the VRF Tier-0 router?

[Didainius]

In fact it can be supplied here as well and the datasource does look it up.

[lvirbalas]

What is the reason to group nsxt_manager_id and nsxt_tier0_router_id into a TypeSet with MaxItems: 1? Curious, is there a benefit compared to leaving these parameters flat. The reason I'm asking, because we had hit issues with the TypeSet in the past, so just would like to get confirmation that this won't be the case here :)

[Didainius]

The reason was that adjacent block vsphere_network can have more than one and is a TypeSet. I can change this one to TypeList. We can switch back if it allows to specify more than 1 in future.

[lvirbalas]

Ah! I haven't realized it relates to NSX-V's vsphere_network and that more than one can be defined.
It's OK, if you see no technical issues with TypeSet, let's leave it.

[lvirbalas]

Looks great to me!

[vbauzys]

LGTM