Improve 'ipSliceDifference' function memory footprint #567
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Methods
NsxtEdgeGateway.GetAllUnusedExternalIPAddresses
andNsxtEdgeGateway.GetUnusedExternalIPAddresses
perform computations based onnetip.Addr
package.The internal function
ipSliceDifference
is used to allocate a new slice to hold the final results. However, the operations become quite expensive memory wise having big subnets in Edge Gateway. Optimizing this function reduced memory consumption twice (see example below)Example information
One example was allocation
/8
IPv4
subnet (16777213
IPs)Before optimization 2 operations consumed such an amount of memory (

getAllUnusedExternalIPAddresses
- 7703.94MB)After optimization 2 operations of

getAllUnusedExternalIPAddresses
consume such amount (after 3853.80MB vs before 7703.94MB):