Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for DVPG backed imported NSX-T Org VDC networks #564

Merged
merged 10 commits into from
Apr 13, 2023

Conversation

Didainius
Copy link
Collaborator

@Didainius Didainius commented Apr 6, 2023

This PR adds support for importable Distributed Virtual Port Group (DVPG) read via typesVcenterImportableDvpg and types.VcenterImportableDvpg and methods VCDClient.GetVcenterImportableDvpgByName, VCDClient.GetAllVcenterImportableDvpgs, Vdc.GetVcenterImportableDvpgByName, Vdc.GetAllVcenterImportableDvpgs

Additionally, it adds a new test Test_NsxtOrgVdcNetworkImportedDistributedVirtualPortGroup which tests that imported Org VDC network can be backed by DVPG.

Note. Imported network backed by VDC Group can only be created in VDC and not VDC Groups

Test Config adds a new field Dvpg so that DVPG name can be supplied

…DC Network test

Signed-off-by: Dainius Serplis <dserplis@vmware.com>
Signed-off-by: Dainius Serplis <dserplis@vmware.com>
Signed-off-by: Dainius Serplis <dserplis@vmware.com>
Signed-off-by: Dainius Serplis <dserplis@vmware.com>
Signed-off-by: Dainius Serplis <dserplis@vmware.com>
@Didainius Didainius marked this pull request as ready for review April 11, 2023 05:52
Copy link
Collaborator

@lvirbalas lvirbalas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Neat!

Signed-off-by: Dainius Serplis <dserplis@vmware.com>
@Didainius Didainius removed the request for review from dataclouder April 13, 2023 06:16
Signed-off-by: Dainius Serplis <dserplis@vmware.com>
Signed-off-by: Dainius Serplis <dserplis@vmware.com>
Signed-off-by: Dainius Serplis <dserplis@vmware.com>
@Didainius Didainius merged commit 2a4976d into vmware:main Apr 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants