Add NSX-T Firewall Group Support (Security Groups and IP Sets) #368
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Dainius Serplis <dserplis@vmware.com>
Didainius
force-pushed
the
security-groups-pr
branch
from
92f3a2b to
858d5a0
Compare
Signed-off-by: Dainius Serplis <dserplis@vmware.com>
lvirbalas
reviewed
Apr 19, 2021
govcd/nsxt_firewall_group.go
Outdated
| } | ||
|
|
||
| if firewallGroup.NsxtFirewallGroup.ID == "" { | ||
| return nil, fmt.Errorf("cannot retrieve associated VMs for NSX-T Firewall Group without ID") |
There was a problem hiding this comment.
Suggested change
| return nil, fmt.Errorf("cannot retrieve associated VMs for NSX-T Firewall Group without ID") | |
| return nil, fmt.Errorf("cannot retrieve associated VMs for NSX-T Firewall Group without ID") |
CHANGELOG.md
Outdated
| @@ -2,7 +2,27 @@ | |||
|
|
|||
| * Added method `vdc.QueryEdgeGateway` [#364](https://github.com/vmware/go-vcloud-director/pull/364) | |||
| * Deprecated `vdc.GetEdgeGatewayRecordsType` [#364](https://github.com/vmware/go-vcloud-director/pull/364) | |||
| * Added NSX-T Firewall Group (Security Groups and IP Set) support by using structures | |||
There was a problem hiding this comment.
Suggesting below just because I got puzzled by the meaning of it all the way until I reached the very last file in the PR 😄
Suggested change
| * Added NSX-T Firewall Group (Security Groups and IP Set) support by using structures | |
| * Added NSX-T Firewall Group type (which represents a Security Group or an IP Set) support by using structures |
Signed-off-by: Dainius Serplis <dserplis@vmware.com>
lvirbalas
approved these changes
Apr 19, 2021
CHANGELOG.md
Outdated
| @@ -2,7 +2,27 @@ | |||
|
|
|||
| * Added method `vdc.QueryEdgeGateway` [#364](https://github.com/vmware/go-vcloud-director/pull/364) | |||
| * Deprecated `vdc.GetEdgeGatewayRecordsType` [#364](https://github.com/vmware/go-vcloud-director/pull/364) | |||
| * Added NSX-T Firewall Group type (which represents a Security Group or an IP Set) support by using | |||
| structures `NsxtFirewallGroup` and `NsxtFirewallGroupMemberVms`. The following methods are | |||
| introduced for managing Security Groups and IpP Sets: `Vdc.CreateNsxtFirewallGroup`, | |||
There was a problem hiding this comment.
Suggested change
| introduced for managing Security Groups and IpP Sets: `Vdc.CreateNsxtFirewallGroup`, | |
| introduced for managing Security Groups and IP Sets: `Vdc.CreateNsxtFirewallGroup`, |
Signed-off-by: Dainius Serplis <dserplis@vmware.com>
Signed-off-by: Dainius Serplis <dserplis@vmware.com>
Signed-off-by: Dainius Serplis <dserplis@vmware.com>
Signed-off-by: Dainius Serplis <dserplis@vmware.com>
Signed-off-by: Dainius Serplis <dserplis@vmware.com>
Signed-off-by: Dainius Serplis <dserplis@vmware.com>
Signed-off-by: Dainius Serplis <dserplis@vmware.com>
Signed-off-by: Dainius Serplis <dserplis@vmware.com>
Signed-off-by: Dainius Serplis <dserplis@vmware.com>
Signed-off-by: Dainius Serplis <dserplis@vmware.com>
Signed-off-by: Dainius Serplis <dserplis@vmware.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds NSX-T Firewall Group support (this endpoint supports setting both - Security Groups and IP Sets).
It does so by introducing the following new types:
NsxtFirewallGroupNsxtFirewallGroupMemberVmsAnd such methods for managing them:
Vdc.CreateNsxtFirewallGroup,NsxtEdgeGateway.CreateNsxtFirewallGroupOrg.GetAllNsxtFirewallGroupsVdc.GetAllNsxtFirewallGroupsOrg.GetNsxtFirewallGroupByName,Vdc.GetNsxtFirewallGroupByNameNsxtEdgeGateway.GetNsxtFirewallGroupByName,Org.GetNsxtFirewallGroupByIdVdc.GetNsxtFirewallGroupById,NsxtEdgeGateway.GetNsxtFirewallGroupByIdNsxtFirewallGroup.Update,NsxtFirewallGroup.DeleteNsxtFirewallGroup.GetAssociatedVms,NsxtFirewallGroup.IsSecurityGroupNsxtFirewallGroup.IsIpSetAdditionally it adds the following new methods to improve test cleanup framework (add support for VM cleanup when they are spread in multiple VDCs)
Org.QueryVmListandOrg.QueryVmByIdto find VM by ID in an OrgIMPROVEMENTS: