Add Vdc Vm compute policies functionality #334
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Merge branch 'master' of github.com:vmware/go-vcloud-director
Merge branch 'master' of github.com:vmware/go-vcloud-director
# Conflicts: # types/v56/types.go
vbauzys
requested review from
dataclouder,
Didainius and
lvirbalas
and removed request for
dataclouder
lvirbalas
requested changes
Sep 17, 2020
govcd/vdcComputePolicy.go
Outdated
| util.Logger.Printf("[TRACE] Set Compute Policies started") | ||
|
|
||
| if !vdc.client.IsSysAdmin { | ||
| return nil, fmt.Errorf("functionality requires system administrator privileges") |
There was a problem hiding this comment.
Nit, suggesting to capitalize:
Suggested change
| return nil, fmt.Errorf("functionality requires system administrator privileges") | |
| return nil, fmt.Errorf("functionality requires System Administrator privileges") |
There was a problem hiding this comment.
changed in all project files
There was a problem hiding this comment.
Missing space after the changes - System Administratorprivileges
…_sizing_policies # Conflicts: # CHANGELOG.md
Merge branch 'master' of github.com:vmware/go-vcloud-director
Didainius
reviewed
Sep 25, 2020
Didainius
approved these changes
Sep 25, 2020
dataclouder
approved these changes
Sep 30, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Functionality needed for VM sizing policy.
New functionality:
VDC compute policy can be created in 32 version but getting doesn't work well on 32 version. Also doesn't have UI for that. So overall limitation is 33 API version (All functionality works in from VCD 10.0+)