Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Affinity rules #313

Merged
merged 11 commits into from
Jun 23, 2020
Merged

Affinity rules #313

merged 11 commits into from
Jun 23, 2020

Conversation

dataclouder
Copy link
Contributor

@dataclouder dataclouder commented May 26, 2020 •
edited
Loading

Implement VM affinity rules CRUD:

  • vdc.CreateVmAffinityRuleAsync
  • vdc. CreateVmAffinityRule
  • vdc.GetAllVmAffinityRuleList
  • vdc.GetVmAffinityRuleList
  • vdc.GetVmAntiAffinityRuleList
  • vdc.GetVmAffinityRuleByHref
  • vdc.GetVmAffinityRulesByName
  • vdc.GetVmAffinityRuleById
  • vdc.GetVmAffinityRuleByNameOrId
  • VmAffinityRule.Delete
  • VmAffinityRule.Update
  • VmAffinityRule.SetMandatory
  • VmAffinityRule.SetEnabled
  • VmAffinityRule.Refresh

Test with:

go test -tags functional -check.vv -timeout 0  \
  -vcd-skip-vapp-creation \
  -check.f Test_VmAffinityRule \
  -vcd-verbose

Giuseppe Maxia added 2 commits May 26, 2020 17:12
[skip ci] Update CHANGELOG
23ca1ff
Improve affinity rule test
a34b4fa 
Add handling of temporary vApps with GOVCD_KEEP_TEST_OBJECTS
@dataclouder dataclouder marked this pull request as ready for review May 31, 2020 18:47
vbauzys
vbauzys suggested changes Jun 3, 2020
View reviewed changes
Copy link
Contributor

@vbauzys vbauzys left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall looks good.

vbauzys
vbauzys approved these changes Jun 4, 2020
View reviewed changes
Copy link
Contributor

@vbauzys vbauzys left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Verified on 9.7 Cassini.
Fails on home env 9.5 and 10.1 as envs don't have two ESXI.

Didainius
Didainius approved these changes Jun 10, 2020
View reviewed changes
lvirbalas
lvirbalas approved these changes Jun 18, 2020
View reviewed changes
Copy link
Collaborator

@lvirbalas lvirbalas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for a clean PR. Only a few suggestions and a question.

@dataclouder dataclouder merged commit 17e533a into vmware:master Jun 23, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lvirbalas lvirbalas lvirbalas approved these changes

@Didainius Didainius Didainius approved these changes

@vbauzys vbauzys vbauzys approved these changes

Assignees
No one assigned
Labels
cla-not-required
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@dataclouder @lvirbalas @Didainius @vbauzys @vmwclabot