Add support for firewall rule handling using NSX-V edge gateway API #247
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dataclouder
suggested changes
Oct 16, 2019
|
Acceptance tests passed on 9.5 and 10 |
vbauzys
approved these changes
Oct 22, 2019
| // GetNsxvFirewallRuleById retrieves types.EdgeFirewallRule by firewall rule ID as shown in the UI using proxied | ||
| // NSX-V API. | ||
| // It returns and error `ErrorEntityNotFound` if the firewall rule is not found | ||
| func (egw *EdgeGateway) GetNsxvFirewallRuleById(id string) (*types.EdgeFirewallRule, error) { |
There was a problem hiding this comment.
Get and delete use internal IDs or UI IDs. From comment I am not sure
There was a problem hiding this comment.
Thanks. Improved comments.
funky81
added a commit
to funky81/go-vcloud-director
that referenced
this pull request
Oct 22, 2019
…re#253) * Deprecated find disk functions and added new get Disk functions * change getDisk to be getDisks * Improve tests * Updated to use parent - enforced implementation Signed-off-by: Vaidotas Bauzys <vbauzys@vmware.com> (cherry picked from commit 9f7abf2) Add support for firewall rule handling using NSX-V edge gateway API (vmware#247) * Added methods `CreateNsxvFirewallRule()`, `UpdateNsxvFirewallRule()`, `GetNsxvFirewallRuleById()`, `DeleteNsxvFirewallRuleById()` which use the proxied NSX-V API of advanced edge gateway for handling firewall rules * Added methods `GetFirewallParams()`, `UpdateFirewallParams()` for changing global firewall settings * Added method `GetAnyVnicIndexByNetworkName()` to for easier interface (vNic) lookup in edge gateway * Added method `ExecuteParamRequestWithCustomError()` which adds query parameter support on top of `ExecuteRequestWithCustomError()` (cherry picked from commit a6af6b4)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds:
CreateNsxvFirewall(),UpdateNsxvFirewall(),GetNsxvFirewallById(),DeleteNsxvFirewallById()andGetAllNsxvFirewallRules()GetFwGeneralParams(),UpdateFwGeneralParams()GetAnyVnicIndexByNetworkName()to for easier interface (vNic) lookup in edge gatewayExecuteParamRequestWithCustomError()which adds query parameter support on top ofExecuteRequestWithCustomError()EdgeFirewallRuleandFwGeneralParamsWithXmlfor firewall manipulationNote Full test suite passed on vCD 9.5 and 10