Add load balancer virtual server CRUD #215
Conversation
| Media string `yaml:"mediaName,omitempty"` | ||
| MediaPath string `yaml:"mediaPath,omitempty"` | ||
| Media string `yaml:"mediaName,omitempty"` | ||
| PhotonOsOvaPath string `yaml:"photonOsOvaPath,omitempty"` |
There was a problem hiding this comment.
I think this item should go under OVA
There was a problem hiding this comment.
Is there any way we could avoid adding one more parameter to the test config? Why does LB test explicitly need Photon? Wouldn't other OVAs with VMware Tools (setup correctly) work?
I'm thinking that either way most of us should be using a capable OVA for the tests, so I suggest we skip or fail LB test if the OVA is not capable enough as opposed to adding one more parameter.
@dataclouder @vbauzysvmware ?
There was a problem hiding this comment.
As far as the OVA capability - inside the test there is a script which relies on guest customization, python3, specific firewall disable script and being able to set IPs properly. Not all OSes do it in exactly the same way. It would be overkill to identify if an OS supports all that.
There was a problem hiding this comment.
Changed to catalogItem as agreed. Now it checks if catalogItem is Photon OS. If it's not - just skips the test.
govcd/sample_govcd_test_config.json
Outdated
| "mediaName": "uploadedMediaName", | ||
| "//": "Relative path for Photon OS image or existing image name (as it appears in the Catalog UI).", | ||
| "//": "the Catalog UI). This is required for load balancer integration test. If the image ", | ||
| "//": "already exists in your environment just set it's name here to reuse it", |
govcd/sample_govcd_test_config.yaml
Outdated
|
|
||
| # Relative path for Photon OS image or existing image name (as it appears in the Catalog UI). | ||
| # This is required for load balancer integration test. If the image already exists in your | ||
| # environment just set it's name here to reuse it (e.g. photon-hw11-3.0-26156e2.ova, photon-os) |
|
NP. |
|
Fix/workaround added for #218 |
Work continues on introducing edge gateway load balancers https://github.com/terraform-providers/terraform-provider-vcd/issues/223
NOTE Until a next PR being submitted one must manually enable load balancing (and advanced load balancing). This can be done in
Edge Gateway -> Load balancer -> Global configuration. Enable both Enabled and Acceleration Enabled as it will not work otherwise until we have this configuration in govcd code (my next PR after this is merged as it has a dependency).