Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

"func (catalog *Catalog) Delete(force, recursive bool) error" ignores task and return immediatelly #390

Closed
Didainius opened this issue Jul 3, 2021 · 0 comments
Closed

"func (catalog *Catalog) Delete(force, recursive bool) error" ignores task and return immediatelly #390

Didainius opened this issue Jul 3, 2021 · 0 comments
Assignees
@dataclouder

Comments

@Didainius
Copy link
Collaborator

Catalog deletion function does not take into account returned task and responds immediately while catalog deletion task is running and may even fail.

This needs to be fixed in order to properly track catalog deletion and catch any errors.
@Didainius Didainius self-assigned this Jul 3, 2021
@dataclouder dataclouder assigned dataclouder and unassigned Didainius Jul 3, 2021
dataclouder pushed a commit to dataclouder/go-vcloud-director that referenced this issue Jul 5, 2021
Fix Issue vmware#390: catalog.Delete() ignores task
5258057 
Signed-off-by: Giuseppe Maxia <gmaxia@vmware.com>
@dataclouder dataclouder mentioned this issue Jul 5, 2021
Merged
dataclouder added a commit that referenced this issue Jul 28, 2021
@dataclouder
Fix catalog delete (#392)
4ac1946 
* Fix Issue #390: catalog.Delete() ignores task

Signed-off-by: Giuseppe Maxia <gmaxia@vmware.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@dataclouder dataclouder

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@dataclouder @Didainius