Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

builder: warn when using tcc with -prod #9288

Merged
merged 2 commits into from
Mar 14, 2021
Merged

Conversation

ntrel
Copy link
Contributor

@ntrel ntrel commented Mar 13, 2021

Fixes #9261.

@spytheman
Copy link
Member

This notice should have a way to be turned off, otherwise the -prod tests will need a way to filter it 🤔 .

@ntrel ntrel marked this pull request as ready for review March 13, 2021 11:37
@medvednikov
Copy link
Member

I wouldn't say "not recommended", I'd say "incompatible" or "doesn't do anything" :)

@ntrel
Copy link
Contributor Author

ntrel commented Mar 13, 2021

@medvednikov Wikipedia says tcc does do some simple optimisations:
"TCC performs a few optimizations, such as constant propagation for all operations, multiplications and divisions are optimized to shifts when appropriate, and comparison operators are specially optimized (by maintaining a special cache for the processor flags). It also does some simple register allocation, which prevents many extraneous save/load pairs inside a single statement. "

@medvednikov medvednikov merged commit df46fe1 into vlang:master Mar 14, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

V should warn if -prod used and only tcc is available.
3 participants