Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

x.crypto.chacha20: enables supports for 64-bit counter #24053

Merged
merged 4 commits into from
Mar 27, 2025

Conversation

blackshirt
Copy link
Contributor

@blackshirt blackshirt commented Mar 26, 2025

This PR enables partial support for creating ChaCha20 cipher with 64-bit counter, see (#23904) issues about this features requested. I call its a partial support, because not all functionality was availables for 64-bit counter variant of ChaCha20 ciphers for current time of writing, especially for xor_key_stream, it still need to be looked again. The .encrypt method was tested working with this new variant of cipher. I am having difficulty finding trusted sources that can be used as references.

With this PR merged, its possible to create new variant of ChaCha20 stream cipher with 64-bit counter, by providing 8-bytes length of nonce into new_cipher routine.
The test has been added with samples of data generates from modified ptyhon script.

Updates:

I have add a test for xor_key_stream behaviour for ChaCha20 cipher with 64-bit counter
The golang script to produce verified output was included in the comments of the test files.

Thanks

Copy link

Connected to Huly®: V_0.6-22444

@blackshirt blackshirt changed the title x.crypto.chacha20: partially activated supports for 64-bit counter x.crypto.chacha20: enables partial supports for 64-bit counter Mar 26, 2025
@blackshirt blackshirt changed the title x.crypto.chacha20: enables partial supports for 64-bit counter x.crypto.chacha20: enables supports for 64-bit counter Mar 27, 2025
@spytheman spytheman merged commit 19a6668 into vlang:master Mar 27, 2025
62 of 63 checks passed
@blackshirt blackshirt deleted the 64bit-counter-features branch March 27, 2025 20:18
@blackshirt
Copy link
Contributor Author

Thanks for merging it. There are several areas that can be improved later. I think its solid enough for now, i will left it as is, and continues my other work..
Good days

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants