-
-
Notifications
You must be signed in to change notification settings - Fork 2.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
x.crypto.chacha20: enables supports for 64-bit counter #24053
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Connected to Huly®: V_0.6-22444 |
2 tasks
spytheman
reviewed
Mar 27, 2025
spytheman
reviewed
Mar 27, 2025
spytheman
reviewed
Mar 27, 2025
spytheman
reviewed
Mar 27, 2025
spytheman
reviewed
Mar 27, 2025
spytheman
reviewed
Mar 27, 2025
Thanks for merging it. There are several areas that can be improved later. I think its solid enough for now, i will left it as is, and continues my other work.. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR enables partial support for creating ChaCha20 cipher with 64-bit counter, see (#23904) issues about this features requested. I call its a partial support, because not all functionality was availables for 64-bit counter variant of ChaCha20 ciphers for current time of writing, especially for
xor_key_stream
, it still need to be looked again. The.encrypt
method was tested working with this new variant of cipher. I am having difficulty finding trusted sources that can be used as references.With this PR merged, its possible to create new variant of ChaCha20 stream cipher with 64-bit counter, by providing 8-bytes length of nonce into
new_cipher
routine.The test has been added with samples of data generates from modified ptyhon script.
Updates:
I have add a test for
xor_key_stream
behaviour for ChaCha20 cipher with 64-bit counterThe golang script to produce verified output was included in the comments of the test files.
Thanks